-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching from saving lastUpdated on source, to saving lastUpdated on targets #61
Comments
Whow, lots of new activity since I last checked! Thanks for continuing with this project! I solved this (see fork) with logging to a local .csv file on successful sync only. Combined this with a lookup in that csv file before each sync and never had duplicate entries in Garmin connect since. Added bonus is local logging and history of the measurements in a format that can easily be imported in other scripts/services. |
@longstone my solution based on the above mentioned csv input can be found here By default it is now fetching measurements starting from 3 days ago, comparing the measurements to what is found in the local csv, if found: discard, if not found: upload. Notable changes to the debug output are:
Please note that this code is fully linted and thus if you agree on this approach, I'll close #69 and create a new pull request. |
@stynoo then I'll suggest going for the one with CSV storage, as it's ok with lint and also refactored. However, let's do it and discuss this tough there! Thanks for your effort 🙏 |
From my point of view, changing the behavior would need some bigger refactoring.
See discussion in PR #38 :
Support wanted here for fixing this behaviour.
The text was updated successfully, but these errors were encountered: