Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react types to 19.0.2 #250

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Update react types to 19.0.2 #250

merged 2 commits into from
Jan 7, 2025

Conversation

Mad-Kat
Copy link
Collaborator

@Mad-Kat Mad-Kat commented Dec 29, 2024

Closes #248
Updated @types/react to 19.0.2 and removed our own FunctionComponent as the new React.FunctionComponent is now almost the same.

Copy link

changeset-bot bot commented Dec 29, 2024

🦋 Changeset detected

Latest commit: 3f1825e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
next-yak Patch
yak-swc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Mad-Kat Mad-Kat marked this pull request as ready for review December 29, 2024 14:58
@Mad-Kat Mad-Kat requested a review from jantimon December 29, 2024 14:59
jantimon
jantimon previously approved these changes Dec 29, 2024
Copy link
Collaborator

@jantimon jantimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Mad-Kat
Copy link
Collaborator Author

Mad-Kat commented Dec 30, 2024

Thanks for the review.

This is a stacked PR. So #249 should be approved and merged first

@Mad-Kat Mad-Kat force-pushed the update-react-types branch from 1e07786 to dec1191 Compare January 6, 2025 12:38
Base automatically changed from use-pnpm-catalog to main January 7, 2025 06:41
@Mad-Kat Mad-Kat dismissed jantimon’s stale review January 7, 2025 06:41

The base branch was changed.

@Mad-Kat Mad-Kat force-pushed the update-react-types branch from dec1191 to 3f1825e Compare January 7, 2025 06:45
Copy link

codspeed-hq bot commented Jan 7, 2025

CodSpeed Performance Report

Merging #250 will not alter performance

Comparing update-react-types (3f1825e) with main (10adce8)

Summary

✅ 2 untouched benchmarks

@Mad-Kat Mad-Kat requested a review from jantimon January 7, 2025 06:56
@jantimon jantimon merged commit 7f90169 into main Jan 7, 2025
8 checks passed
@jantimon jantimon deleted the update-react-types branch January 7, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Types error with @types/[email protected]
3 participants