Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The plugin generates unnecessary links to files in manifest #217

Closed
in-in opened this issue Jul 30, 2020 · 2 comments
Closed

The plugin generates unnecessary links to files in manifest #217

in-in opened this issue Jul 30, 2020 · 2 comments

Comments

@in-in
Copy link

in-in commented Jul 30, 2020

config:

new FaviconsWebpackPlugin({
    ...
    'favicons': {
      'icons': {
        "android": [
          "android-chrome-192x192.png",
          "android-chrome-512x512.png",
        ],
        "appleIcon": [
          "apple-touch-icon-180x180.png",
        ],
        'appleStartup': false,
        'coast': false,
        'firefox': false,
        'windows': false,
        'yandex': false,
      },
    },
  }),

output files:

android-chrome-192x192.png
android-chrome-512x512.png
apple-touch-icon-180x180.png
favicon-16x16.png
favicon-32x32.png
favicon-48x48.png
favicon.ico
manifest.json

manifest.json:

"icons": [
    {
      "src": "/assets/favicon/android-chrome-36x36.png",
      "sizes": "36x36",
      "type": "image/png"
    },
    {
      "src": "/assets/favicon/android-chrome-48x48.png",
      "sizes": "48x48",
      "type": "image/png"
    },
    {
      "src": "/assets/favicon/android-chrome-72x72.png",
      "sizes": "72x72",
      "type": "image/png"
    },
    {
      "src": "/assets/favicon/android-chrome-96x96.png",
      "sizes": "96x96",
      "type": "image/png"
    },
    {
      "src": "/assets/favicon/android-chrome-144x144.png",
      "sizes": "144x144",
      "type": "image/png"
    },
    {
      "src": "/assets/favicon/android-chrome-192x192.png",
      "sizes": "192x192",
      "type": "image/png"
    },
    {
      "src": "/assets/favicon/android-chrome-256x256.png",
      "sizes": "256x256",
      "type": "image/png"
    },
    {
      "src": "/assets/favicon/android-chrome-384x384.png",
      "sizes": "384x384",
      "type": "image/png"
    },
    {
      "src": "/assets/favicon/android-chrome-512x512.png",
      "sizes": "512x512",
      "type": "image/png"
    }
  ]

Expected result for manifest.json:

    "icons": [
        {
            "src": "/android-chrome-192x192.png",
            "sizes": "192x192",
            "type": "image/png"
        },
        {
            "src": "/android-chrome-512x512.png",
            "sizes": "512x512",
            "type": "image/png"
        }
    ],
@in-in
Copy link
Author

in-in commented Jul 30, 2020

It looks like this new option doesn't work at all.
202121596126851

@Voltra
Copy link

Voltra commented Jul 31, 2020

The feature only focused on icon generation, not the manifest/HTML generation, see currently open itgalaxy/favicons#315 for HTML generation. Manifest will probably be yet another complete overhaul.

@jantimon jantimon closed this as completed Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants