Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing hacks in createDropDownComponent and useEventRefresh tests #15

Open
jameswilddev opened this issue Oct 24, 2021 · 0 comments
Open

Comments

@jameswilddev
Copy link
Owner

jameswilddev commented Oct 24, 2021

There are a few instances of the following in the createDropDownComponent and useEventRefresh tests:

  // Some aspect of unmounting seems to be asynchronous in this test, and not
  // waiting seems to mean that window dimension changes in other tests trigger
  // changes here.
  await new Promise((resolve) => setTimeout(resolve, 10));

It would be ideal if these could be eliminated somehow.

@jameswilddev jameswilddev changed the title Timing hacks in createDropDownComponent tests Timing hacks in createDropDownComponent and useEventRefresh tests Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant