Why does WireTx require send_log_{str,fmt}?

[hvraven]

I am currently working on a custom wire implementation for a project and ran into the logging functions required by the WireTx trait. These are annoying to implement, and not needed in every project. I think they shouldn't be on this code level and would expect logging functionality to be implemented on top of the WireTx trait.

Is there a specific reason why these are required in WireTx? If not I will try to make a proper patch to remove them from the trait.

[jamesmunns]

I am open to ideas on how they could be implemented on top of the wire trait, but they are difficult to implement without either:

• exposing the temporary buffer for usage (which might also require exposing the underlying locking mechanism)
• requiring alloc
• Using another temporary buffer just for formatting

So, I'm in the awkward position where:

• Punching through the abstraction is desirable for efficiency reasons
• It's an additional burden on wire implementors

that being said - postcard-rpc itself never uses these endpoints, if you don't need them in your application, you could return an error (or panic) if they are called. We could also add a default impl that does that.