From c417c1e4e661ede78b07e13a1794b217837e2651 Mon Sep 17 00:00:00 2001
From: Jake Ireland <jakewilliami@icloud.com>
Date: Mon, 26 Sep 2022 17:10:54 +1300
Subject: [PATCH 01/12] Move realpath path expansion call to within
 _ishidden_unix

We need to expand the path into its real path in order to correctly
assess whether the file begins with a full stop.  However, we only
need to check this for Unix.

We should probably add some tests on macOS and BSD in particular to
see if our custom C calls and low-level functions still work without
realpath at the top-most level, or if we need to call normpath as well.
---
 src/HiddenFiles.jl | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/src/HiddenFiles.jl b/src/HiddenFiles.jl
index 0bfe883..bd87788 100644
--- a/src/HiddenFiles.jl
+++ b/src/HiddenFiles.jl
@@ -14,10 +14,13 @@ Check if a file or directory is hidden.
 On Unix-like systems, a file or directory is hidden if it starts with a full stop/period (`U+002e`).  On Windows systems, this function will parse file attributes to determine if the given file or directory is hidden.
 
 !!! note
-    On macOS and BSD, this function will also check the `st_flags` field from `stat` to check if the `UF_HIDDEN` flag has been set.
+    On Unix-like systems, in order to correctly determine if the file begins with a full stop, we must first expand the path to its real path.
 
 !!! note
-    On macOS, any file or directory within a [package](https://developer.apple.com/library/archive/documentation/CoreFoundation/Conceptual/CFBundles/DocumentPackages/DocumentPackages.html) or a [bundle](https://developer.apple.com/library/archive/documentation/CoreFoundation/Conceptual/CFBundles/AboutBundles/AboutBundles.html) will be considered hidden.
+    On operating systems deriving from BSD (i.e., *BSD, macOS), this function will also check the `st_flags` field from `stat` to check if the `UF_HIDDEN` flag has been set.
+
+!!! note
+    On macOS, any file or directory within a [package](https://developer.apple.com/library/archive/documentation/CoreFoundation/Conceptual/CFBundles/DocumentPackages/DocumentPackages.html) or a [bundle](https://developer.apple.com/library/archive/documentation/CoreFoundation/Conceptual/CFBundles/AboutBundles/AboutBundles.html) will also be considered hidden.
 """
 ishidden
 
@@ -32,8 +35,8 @@ include("docs.jl")
     
     # Trivial Unix check
     _isdotfile(f::AbstractString) = startswith(basename(f), '.')
-    # Account for ZFS
-    _ishidden_unix(f::AbstractString) = _isdotfile(f) || (iszfs() && _ishidden_zfs())
+    # Check dotfiles, but also account for ZFS
+    _ishidden_unix(f::AbstractString) = _isdotfile(realpath(f)) || (iszfs() && _ishidden_zfs())
     
     @static if Sys.isbsd()  # BDS-related; this is true for macOS as well
         # https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/chflags.2.html
@@ -183,7 +186,7 @@ end
 # the real path out, and apply the branch's _ishidden function to that path to get a final result
 function ishidden(f::AbstractString)
     ispath(f) || throw(Base.uv_error("ishidden($(repr(f)))", Base.UV_ENOENT))
-    return _ishidden(realpath(f))
+    return _ishidden(f)
 end
 
 

From 78a54e7fb0d806917d0daeb58a6f6e41604e9c49 Mon Sep 17 00:00:00 2001
From: Jake Ireland <jakewilliami@icloud.com>
Date: Mon, 26 Sep 2022 17:33:47 +1300
Subject: [PATCH 02/12] Ensure package/bundle check expands real path; add
 further tests

For reasons described in updated documentation, the package/bundle
check for macOS should also expand to real path.  Implement tests to
test that our functionality still works.
---
 src/HiddenFiles.jl | 8 ++++++--
 src/docs.jl        | 3 +++
 test/runtests.jl   | 4 ++++
 3 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/src/HiddenFiles.jl b/src/HiddenFiles.jl
index bd87788..c33cde9 100644
--- a/src/HiddenFiles.jl
+++ b/src/HiddenFiles.jl
@@ -140,9 +140,13 @@ include("docs.jl")
         # If a file or directory exists inside a package or bundle, then it is hidden.  Packages or bundles themselves
         # are not necessarily hidden.
         function _exists_inside_package_or_bundle(f::AbstractString)
-            # This assumes that f has already been modified with the realpath function, as if it hasn't,
+            # This function necessitates that f has is modified with the realpath function, as if it hasn't,
             # it is possible that f has a trailing slash, meaning its dirname is still itself
-            f = dirname(f)
+            f = dirname(realpath(f))
+            
+            # We can't check the root directory, as this doesn't have any metadata information, so
+            # _k_mditem_content_type_tree will fail.  Otherwise, we start at the parent directory of the
+            # given file, and check if any of its parents are packages or bundles.
             while f != "/"
                 _ispackage_or_bundle(f) && return true
                 f = dirname(f)
diff --git a/src/docs.jl b/src/docs.jl
index 8a23c92..15f0001 100644
--- a/src/docs.jl
+++ b/src/docs.jl
@@ -154,6 +154,9 @@ _exists_inside_package_or_bundle(f::AbstractString) -> Bool
 Determines whether the given path exists inside a package or bundle on macOS.  If it does, the path will be considered hidden.
 
 See also: [`_ispackage_or_bundle`](@ref), [`_ishidden_macos`](@ref)
+
+!!! note
+    This function will expand the given file to its real path, as it is possible that the file provided has a trailing slash, meaning the first "parent" this function will check is itself.  This also makes relative paths much simpler to work with.
 """
 _exists_inside_package_or_bundle
 
diff --git a/test/runtests.jl b/test/runtests.jl
index 427de09..29b1885 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -38,6 +38,10 @@ using Test
                 # Case 4: Packages and bundles
                 @test !ishidden("/System/Applications/Utilities/Terminal.app")
                 @test ishidden("/System/Applications/Utilities/Terminal.app/Contents")
+                @test ishidden("/System/Applications/Utilities/Terminal.app/Contents/../../Terminal.app/Contents")
+                @test ishidden("/////System/Applications/Utilities/Terminal.app/Contents/../Contents")
+                @test ishidden("/System/Applications/Utilities/Terminal.app/Contents/../Contents///MacOS////../MacOS/../../Contents/MacOS/Terminal///")
+                @test !ishidden("/")
                 @test ishidden("/System/Applications/Utilities/Terminal.app/Contents/")  # This should be the same as above, as we expand all paths using realpath
                 @test !HiddenFiles._ispackage_or_bundle("/System/Applications/Utilities/Terminal.app/Contents/")
                 @test HiddenFiles._exists_inside_package_or_bundle("/System/Applications/Utilities/Terminal.app/Contents/")

From 01584ca87cd8aaebc08cb15fa51476f812f705f6 Mon Sep 17 00:00:00 2001
From: Jake Ireland <jakewilliami@icloud.com>
Date: Mon, 26 Sep 2022 17:35:33 +1300
Subject: [PATCH 03/12] Ensure path checking before _ishidden expands to
 realpath

---
 src/HiddenFiles.jl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/HiddenFiles.jl b/src/HiddenFiles.jl
index c33cde9..973799d 100644
--- a/src/HiddenFiles.jl
+++ b/src/HiddenFiles.jl
@@ -189,7 +189,7 @@ end
 # Each OS branch defines its own _ishidden function.  In the main ishidden function, we check that the path exists, expand
 # the real path out, and apply the branch's _ishidden function to that path to get a final result
 function ishidden(f::AbstractString)
-    ispath(f) || throw(Base.uv_error("ishidden($(repr(f)))", Base.UV_ENOENT))
+    ispath(realpath(f)) || throw(Base.uv_error("ishidden($(repr(f)))", Base.UV_ENOENT))
     return _ishidden(f)
 end
 

From c5ffd99a932022e2b2ddf992150965c58cf45dda Mon Sep 17 00:00:00 2001
From: Jake Ireland <jakewilliami@icloud.com>
Date: Mon, 26 Sep 2022 18:26:50 +1300
Subject: [PATCH 04/12] Pass real path result around for use where needed

Some internal functions need to use the real path, where some don't.
We check calculate the real path anyway, to ensure that the path
exists, so we are now going to pass it around to the individual
_ishidden-* functions for use as required.
---
 src/HiddenFiles.jl | 26 ++++++++++++++++----------
 src/docs.jl        | 28 +++++++++++++++++++++-------
 test/runtests.jl   | 11 ++++++++++-
 3 files changed, 47 insertions(+), 18 deletions(-)

diff --git a/src/HiddenFiles.jl b/src/HiddenFiles.jl
index 973799d..33a9ede 100644
--- a/src/HiddenFiles.jl
+++ b/src/HiddenFiles.jl
@@ -30,13 +30,14 @@ include("docs.jl")
     include("utils/zfs.jl")
     if iszfs()  # @static breaks here # ZFS
         error("not yet implemented")
-        _ishidden_zfs(f::AbstractString) = error("not yet implemented")
+        _ishidden_zfs(f::AbstractString, rp::AbstractString) = error("not yet implemented")
+        _ishidden = _ishidden_zfs
     end
     
     # Trivial Unix check
     _isdotfile(f::AbstractString) = startswith(basename(f), '.')
     # Check dotfiles, but also account for ZFS
-    _ishidden_unix(f::AbstractString) = _isdotfile(realpath(f)) || (iszfs() && _ishidden_zfs())
+    _ishidden_unix(f::AbstractString, rp::AbstractString) = _isdotfile(rp) || (iszfs() && _ishidden_zfs("", ""))
     
     @static if Sys.isbsd()  # BDS-related; this is true for macOS as well
         # https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/chflags.2.html
@@ -63,7 +64,7 @@ include("docs.jl")
         # https://github.com/davidkaya/corefx/blob/4fd3d39f831f3e14f311b0cdc0a33d662e684a9c/src/System.IO.FileSystem/src/System/IO/FileStatus.Unix.cs#L88
         _isinvisible(f::AbstractString) = (_st_flags(f) & UF_HIDDEN) == UF_HIDDEN    
         
-        _ishidden_bsd_related(f::AbstractString) = _ishidden_unix(f) || _isinvisible(f)
+        _ishidden_bsd_related(f::AbstractString, rp::AbstractString) = _ishidden_unix(f, rp) || _isinvisible(rp)
     end
     
     @static if Sys.isapple()  # macOS/Darwin
@@ -142,7 +143,7 @@ include("docs.jl")
         function _exists_inside_package_or_bundle(f::AbstractString)
             # This function necessitates that f has is modified with the realpath function, as if it hasn't,
             # it is possible that f has a trailing slash, meaning its dirname is still itself
-            f = dirname(realpath(f))
+            f = dirname(f)
             
             # We can't check the root directory, as this doesn't have any metadata information, so
             # _k_mditem_content_type_tree will fail.  Otherwise, we start at the parent directory of the
@@ -156,10 +157,10 @@ include("docs.jl")
         
         
         #=== All macOS cases ===#
-        _ishidden_macos(f::AbstractString) = _ishidden_bsd_related(f) || _issystemfile(f) || _exists_inside_package_or_bundle(f)
+        _ishidden_macos(f::AbstractString, rp::AbstractString) = _ishidden_bsd_related(f, rp) || _issystemfile(f) || _exists_inside_package_or_bundle(rp)
         _ishidden = _ishidden_macos
     elseif Sys.isbsd()  # BSD; this excludes macOS through control flow (as macOS is checked for first)
-        _ishidden_bsd(f::AbstractString) = _ishidden_bsd_related(f)
+        _ishidden_bsd(f::AbstractString, rp::AbstractString) = _ishidden_bsd_related(f, rp)
         _ishidden = _ishidden_bsd
     else  # General UNIX
         _ishidden = _ishidden_unix
@@ -171,10 +172,10 @@ elseif Sys.iswindows()
     const FILE_ATTRIBUTE_HIDDEN = 0x2
     const FILE_ATTRIBUTE_SYSTEM = 0x4
     
-    function _ishidden_windows(f::AbstractString)
+    function _ishidden_windows(f::AbstractString, rp::AbstractString)
         # https://docs.microsoft.com/en-gb/windows/win32/api/fileapi/nf-fileapi-getfileattributesa
         # DWORD GetFileAttributesA([in] LPCSTR lpFileName);
-        f_attrs = ccall(:GetFileAttributesA, UInt32, (Cstring,), f)
+        f_attrs = ccall(:GetFileAttributesA, UInt32, (Cstring,), rp)
         
         # https://stackoverflow.com/a/1343643/12069968
         # https://stackoverflow.com/a/14063074/12069968
@@ -189,8 +190,13 @@ end
 # Each OS branch defines its own _ishidden function.  In the main ishidden function, we check that the path exists, expand
 # the real path out, and apply the branch's _ishidden function to that path to get a final result
 function ishidden(f::AbstractString)
-    ispath(realpath(f)) || throw(Base.uv_error("ishidden($(repr(f)))", Base.UV_ENOENT))
-    return _ishidden(f)
+    try
+        rp = realpath(f)
+    catch e
+        isa(e, Base.IOError) && throw(Base.uv_error("ishidden($(repr(f)))", e.code))
+        rethrow()
+    end
+    return _ishidden(f, realpath(f))
 end
 
 
diff --git a/src/docs.jl b/src/docs.jl
index 15f0001..af41ab6 100644
--- a/src/docs.jl
+++ b/src/docs.jl
@@ -1,10 +1,12 @@
 """
 ```julia
-_ishidden(f::AbstractString) -> Bool
+_ishidden(f::AbstractString, rp::AbstractString) -> Bool
 ```
 
 An alias for your system's internal `_ishidden_*` function.
 
+This function also takes an expanded real path, as some internal functions neccesitate a real path.
+
 The reason this is still an internal function is because the main [`ishidden`](@ref) function also checks the validity of the path, so that all internal functions can assume that the path exists.
 
 See also: [`_ishidden_unix`](@ref), [`_ishidden_windows`](@ref), [`_ishidden_macos`](@ref), [`_ishidden_bsd`](@ref), [`_ishidden_zfs`](@ref).
@@ -27,17 +29,23 @@ _isdotfile(f::AbstractString) -> Bool
 ```
 
 Determines if a file or directory is hidden from ordinary directory listings by checking if it starts with a full stop/period (`U+002E`).
+
+!!! note
+    This function expects the path given to be a normalised/real path, so that the base name of the path can be correctly assessed.
 """
 _isdotfile
 
 """
 ```julia
-_ishidden_unix(f::AbstractString) -> Bool
+_ishidden_unix(f::AbstractString, rp::AbstractString) -> Bool
 ```
 
 Determines if a file or directory is hidden from ordinary directory listings by checking if it starts with a full stop/period, or if it is a ZFS mount point on operating systems with a Unix-like interface.
 
 See also: [`_isdotfile`](@ref), [`_ishidden_zfs`](@ref).
+
+!!! note
+    This function expects the path given to be a normalised/real path, so that the base name of the path can be correctly assessed.
 """
 _ishidden_unix
 
@@ -88,12 +96,15 @@ _isinvisible(f::AbstractString) -> Bool
 Determines if the specified file or directory is invisible/hidden, as defined by the Finder flags for the path.
 
 See also: [`_st_flags`](@ref), [`UF_HIDDEN`](@ref).
+
+!!! note
+    This function expects that the file given to it is its real path.
 """
 _isinvisible
 
 """
 ```julia
-_ishidden_bsd_related(f::AbstractString) -> Bool
+_ishidden_bsd_related(f::AbstractString, rp::AbstractString) -> Bool
 ```
 
 Determines if a file or directory on a BSD-related system (i.e., macOS or BSD) is hidden from ordinary directory listings, as defined either by the Unix standard, or by user-defined flags.
@@ -156,13 +167,13 @@ Determines whether the given path exists inside a package or bundle on macOS.  I
 See also: [`_ispackage_or_bundle`](@ref), [`_ishidden_macos`](@ref)
 
 !!! note
-    This function will expand the given file to its real path, as it is possible that the file provided has a trailing slash, meaning the first "parent" this function will check is itself.  This also makes relative paths much simpler to work with.
+    This function necessitates/expects that the file given to it is its real path, as it is possible that the file provided has a trailing slash, meaning the first "parent" this function will check is itself.  This also makes relative paths much simpler to work with.
 """
 _exists_inside_package_or_bundle
 
 """
 ```julia
-_ishidden_macos(f::AbstractString) -> Bool
+_ishidden_macos(f::AbstractString, rp::AbstractString) -> Bool
 ```
 
 Determines if the specified file or directory on macOS is hidden from ordinary directory listings.  There are a few conditions this function needs to check:
@@ -185,7 +196,7 @@ _ishidden_macos
 
 """
 ```julia
-_ishidden_bsd(f::AbstractString) -> Bool
+_ishidden_bsd(f::AbstractString, rp::AbstractString) -> Bool
 ```
 
 Determines if the specified file or directory is hidden from ordinary directory listings by checking the following conditions:
@@ -222,10 +233,13 @@ FILE_ATTRIBUTE_SYSTEM
 
 """
 ```julia
-_ishidden_windows(f::AbstractString) -> Bool
+_ishidden_windows(f::AbstractString, rp::AbstractString) -> Bool
 ```
 
 Determine if the specified file or directory is hidden from ordinary directory listings for operating systems that are derivations of Microsoft Windows NT.
+
+!!! note
+    This function necessitates/expects that the file given to it is its real path.
 """
 _ishidden_windows
 
diff --git a/test/runtests.jl b/test/runtests.jl
index 29b1885..0834062 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -1,6 +1,9 @@
 using HiddenFiles
 using Test
+
 @testset "HiddenFiles.jl" begin
+    randpath(path_len::Integer = 64) = String(rand(Char, path_len))  # this path shouldn't exist
+    
     @static if Sys.isunix()
         function mk_temp_dot_file(parent::String = tempdir())
             tmp_hidden = joinpath(parent, '.' * basename(tempname()))
@@ -46,7 +49,7 @@ using Test
                 @test !HiddenFiles._ispackage_or_bundle("/System/Applications/Utilities/Terminal.app/Contents/")
                 @test HiddenFiles._exists_inside_package_or_bundle("/System/Applications/Utilities/Terminal.app/Contents/")
                 @test !HiddenFiles._exists_inside_package_or_bundle("/bin/")
-                f = String(rand(Char, 32))  # this path shouldn't exist
+                f = randpath()
                 cfstr_nonexistent = HiddenFiles._cfstring_create_with_cstring(f)
                 @test_throws Exception HiddenFiles._mditem_create(cfstr_nonexistent)
                 encoding_mode_nonexistent = 0x1c000101  # this encoding mode should not exist
@@ -100,4 +103,10 @@ using Test
             @test false
         end
     end
+    
+    
+    @testset "HiddenFiles.jl—Path Handling" begin
+        f = randpath()
+        @test_throws Base.IOError ishidden(f)
+    end
 end

From 32a356c354ed23beb07c59a463d62c34bfa9d14d Mon Sep 17 00:00:00 2001
From: Jake Ireland <jakewilliami@icloud.com>
Date: Mon, 26 Sep 2022 18:40:03 +1300
Subject: [PATCH 05/12] Add condition for SystemError for older versions of
 Julia

---
 src/HiddenFiles.jl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/HiddenFiles.jl b/src/HiddenFiles.jl
index 33a9ede..26d3253 100644
--- a/src/HiddenFiles.jl
+++ b/src/HiddenFiles.jl
@@ -193,7 +193,9 @@ function ishidden(f::AbstractString)
     try
         rp = realpath(f)
     catch e
-        isa(e, Base.IOError) && throw(Base.uv_error("ishidden($(repr(f)))", e.code))
+        err_prexif = "ishidden($(repr(f)))"
+        isa(e, SystemError) && throw(Base.uv_error(err_prexif, e.errno))  # Julia 1.0 throws a SystemError when `realpath` fails
+        isa(e, Base.IOError) && throw(Base.uv_error(err_prexif, e.code))
         rethrow()
     end
     return _ishidden(f, realpath(f))

From 8f378b9f4c20fb2141e7eb36e41d8f7686e17a90 Mon Sep 17 00:00:00 2001
From: Jake Ireland <jakewilliami@icloud.com>
Date: Mon, 26 Sep 2022 18:50:21 +1300
Subject: [PATCH 06/12] Correct field call for SystemError after realpath

---
 src/HiddenFiles.jl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/HiddenFiles.jl b/src/HiddenFiles.jl
index 26d3253..877787c 100644
--- a/src/HiddenFiles.jl
+++ b/src/HiddenFiles.jl
@@ -194,7 +194,7 @@ function ishidden(f::AbstractString)
         rp = realpath(f)
     catch e
         err_prexif = "ishidden($(repr(f)))"
-        isa(e, SystemError) && throw(Base.uv_error(err_prexif, e.errno))  # Julia 1.0 throws a SystemError when `realpath` fails
+        isa(e, SystemError) && throw(Base.uv_error(err_prexif, e.errnum))  # Julia 1.0 throws a SystemError when `realpath` fails
         isa(e, Base.IOError) && throw(Base.uv_error(err_prexif, e.code))
         rethrow()
     end

From 9d5b6144b89e4d6b0433cfda307c17adc7961d7c Mon Sep 17 00:00:00 2001
From: Jake Ireland <jakewilliami@icloud.com>
Date: Mon, 26 Sep 2022 20:24:33 +1300
Subject: [PATCH 07/12] Throw SystemError if path error

---
 src/HiddenFiles.jl | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/HiddenFiles.jl b/src/HiddenFiles.jl
index 877787c..07ab8dc 100644
--- a/src/HiddenFiles.jl
+++ b/src/HiddenFiles.jl
@@ -194,8 +194,11 @@ function ishidden(f::AbstractString)
         rp = realpath(f)
     catch e
         err_prexif = "ishidden($(repr(f)))"
-        isa(e, SystemError) && throw(Base.uv_error(err_prexif, e.errnum))  # Julia 1.0 throws a SystemError when `realpath` fails
+        # Julia < 1.3 throws a SystemError when `realpath` fails
+        isa(e, SystemError) && throw(SystemError(err_prexif, e.errnum))
+        # Julia ≥ 1.3 throws an IOError, constructed from UV Error codes
         isa(e, Base.IOError) && throw(Base.uv_error(err_prexif, e.code))
+        # If this fails for some other reason, rethrow
         rethrow()
     end
     return _ishidden(f, realpath(f))

From d77defe38b8cddea9dd82a262980bc843acb43ab Mon Sep 17 00:00:00 2001
From: Jake Ireland <jakewilliami@icloud.com>
Date: Mon, 26 Sep 2022 20:30:19 +1300
Subject: [PATCH 08/12] Correct test to allow older Julia versions to check if
 SystemError

---
 test/runtests.jl | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/runtests.jl b/test/runtests.jl
index 0834062..c1f3d24 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -107,6 +107,7 @@ using Test
     
     @testset "HiddenFiles.jl—Path Handling" begin
         f = randpath()
-        @test_throws Base.IOError ishidden(f)
+        # Julia < 1.3 throws a SystemError when `realpath` fails
+        @test_throws Union{Base.IOError, SystemError} ishidden(f)
     end
 end

From a8adc6e25b707b2e026cac22ab2103529e32dae3 Mon Sep 17 00:00:00 2001
From: Jake Ireland <jakewilliami@icloud.com>
Date: Mon, 26 Sep 2022 20:36:15 +1300
Subject: [PATCH 09/12] Allow SystemError in unit test for test throws if path
 invalid

---
 test/runtests.jl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/runtests.jl b/test/runtests.jl
index c1f3d24..07eb306 100644
--- a/test/runtests.jl
+++ b/test/runtests.jl
@@ -16,7 +16,7 @@ using Test
         @testset "HiddenFiles.jl—General UNIX" begin
             @test ishidden(p)
             @test !ishidden(homedir())
-            @test_throws Base.IOError HiddenFiles.ishidden("~/$(basename(p′))")
+            @test_throws Union{Base.IOError, SystemError} HiddenFiles.ishidden("~/$(basename(p′))")
             @test HiddenFiles.ishidden(expanduser("~/$(basename(p′))"))
         end
         

From 50f073116f9e11a568c553e31f1198cdf2f67b5f Mon Sep 17 00:00:00 2001
From: Jake Ireland <jakewilliami@icloud.com>
Date: Mon, 26 Sep 2022 21:40:05 +1300
Subject: [PATCH 10/12] Manually error if path does not exist

For whatever reason, Julia < 1.2 on Windows does not error on realpath
if the path does not exist.  This is nonstandard behaviour, but the
behaviour nonetheless.  We need to try to construct the real path, and
then manually check if the path exists.
---
 src/HiddenFiles.jl | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/HiddenFiles.jl b/src/HiddenFiles.jl
index 07ab8dc..9529350 100644
--- a/src/HiddenFiles.jl
+++ b/src/HiddenFiles.jl
@@ -190,6 +190,7 @@ end
 # Each OS branch defines its own _ishidden function.  In the main ishidden function, we check that the path exists, expand
 # the real path out, and apply the branch's _ishidden function to that path to get a final result
 function ishidden(f::AbstractString)
+    # If path does not exist, `realpath` will error™
     try
         rp = realpath(f)
     catch e
@@ -201,7 +202,13 @@ function ishidden(f::AbstractString)
         # If this fails for some other reason, rethrow
         rethrow()
     end
-    return _ishidden(f, realpath(f))
+    
+    # Julia < 1.2 on Windows does not error on `realpath` if path does not exist, so we
+    # must do so manually here
+    ispath(rp) || throw(Base.uv_error("ishidden($(repr(f)))", Base.UV_ENOENT))
+    
+    # If we got here, the path exists, and we can continue safely with our _ishidden checks
+    return _ishidden(f, rp)
 end
 
 

From 96011bbf7361d59eb0f1d82bdb9ef7d6411869aa Mon Sep 17 00:00:00 2001
From: Jake Ireland <jakewilliami@icloud.com>
Date: Mon, 26 Sep 2022 21:48:10 +1300
Subject: [PATCH 11/12] Initialise real path variable before try/catch
 statement

---
 src/HiddenFiles.jl | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/HiddenFiles.jl b/src/HiddenFiles.jl
index 9529350..e6ecfc9 100644
--- a/src/HiddenFiles.jl
+++ b/src/HiddenFiles.jl
@@ -191,6 +191,7 @@ end
 # the real path out, and apply the branch's _ishidden function to that path to get a final result
 function ishidden(f::AbstractString)
     # If path does not exist, `realpath` will error™
+    local rp::String
     try
         rp = realpath(f)
     catch e

From 9d31a1b0af74d1ade67be35ca154763d4dae8d1c Mon Sep 17 00:00:00 2001
From: Jake Ireland <jakewilliami@icloud.com>
Date: Tue, 27 Sep 2022 20:40:18 +1300
Subject: [PATCH 12/12] Bump patch version number

---
 Project.toml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Project.toml b/Project.toml
index b0ac001..55ba599 100644
--- a/Project.toml
+++ b/Project.toml
@@ -1,7 +1,7 @@
 name = "HiddenFiles"
 uuid = "d01c2003-3cc0-4d61-912c-b250feb01c5b"
 authors = ["Jake Ireland <jakewilliami@icloud.com> and contributors"]
-version = "0.1.0"
+version = "0.1.1"
 
 [compat]
 julia = "1"