-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimise memory usage: GPU array storage and other small changes #26
Comments
Namely after "smart" feature selection |
Done in commit e911698. |
#25 addresses this broader issue of memory efficiency |
Commit 61b0382 addresses this |
…cations doing this, though it takes a little longer)
…comprehension into map (addresses #26)
Points to consider and possibly implement:
|
Commit 70d7d74 addresses this |
Including concrete types where possible for type stability, and array comprehension instead of `map` where performant. Minor formatting changes. Addresses #26.
Some overview thus-far.These benchmarking results are from tests since we changed the algorithm to run sequentially.
a I did not benchmark prior to this, though it probably wouldn't be hard to NB—: time improvement since last commit can be calculated very easily: julia> improvement(a, b) = ((a - b) / a) * 100
improvement (generic function with 1 method)
julia> improvement(30.689, 7.768)
74.68799895728111 That is to say, there was a 74.7% improvement between times 30.689 s and 7.768 s. |
#24205 in julia lang https://github.com/JuliaLang/julia/issues/
The text was updated successfully, but these errors were encountered: