Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add support for html-webpack-plugin 4 #84

Open
kamthamc opened this issue Mar 25, 2020 · 5 comments
Open

Please add support for html-webpack-plugin 4 #84

kamthamc opened this issue Mar 25, 2020 · 5 comments

Comments

@kamthamc
Copy link

kamthamc commented Mar 25, 2020

html-webpack-plugin 4 has been released. Please add support/upgrade the peer dependencies.

https://dev.to/jantimon/html-webpack-plugin-4-has-been-released-125d

@mmaday
Copy link

mmaday commented Mar 30, 2020

This template is not compatible with html-webpack-plugin v4 because the htmlWebpackPlugin.files object has changed. Refer to jantimon/html-webpack-plugin#1369 for more details.

@kamthamc kamthamc changed the title Please add support/update peerDependencies for html-webpack-plugin 4 Please add support for html-webpack-plugin 4 Apr 3, 2020
@skipjack
Copy link

This is unfortunate especially as it fails silently, just bumped to [email protected] and all of a sudden the site comes up blank (as no scripts are inserted).

@bj00rn
Copy link

bj00rn commented Mar 11, 2021

Are there any ambitions to get fixed?

html-webpack-plugin is currently at v5

If this is a won't fix maybe add disclaimer to the README that this only supports html-webpack-plugin 3 to avoid any confusion and further discussion.

Thanks for great work! 🌷

@jaketrent
Copy link
Owner

@bj00rn Thanks for the note and question. I appreciate your directness and tact.

I do not have a lot of ambition to open personal bandwidth to update this atm. I would be happy to open add someone as a contributor to the repo or transfer it to an owner of interest and ability. Who is interested in making such contributions?

@bj00rn
Copy link

bj00rn commented Mar 15, 2021

@bj00rn Thanks for the note and question. I appreciate your directness and tact.

I do not have a lot of ambition to open personal bandwidth to update this atm. I would be happy to open add someone as a contributor to the repo or transfer it to an owner of interest and ability. Who is interested in making such contributions?

Understood!

Fixed a typo for you in #88 , im guessing you mean html-webpack-plugin @ v3, not webpack @ v3

edit: maybe it wasn't a typo, but html-webpack-plugin makes it more obvious that it's not compatible anymore. html-webpack-plugin docs links to this lib...

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants