-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: spm additional query parameter required for prometheus #4221
Comments
That would be great, as in my case we're using Thanos, and query parameter is a hard requirement for us (like the namespace), and can't alter this requirement, as I don't have access to that component. For the Bearer token I use the
this, plus RoleBinding of ClusterRole type:
but I'm getting an error which I can't make anything out of it, so I'm assuming is because of the missing required namespace parameter..., but not 100% sure...
cc @rbaumgar |
@hkailantzis I don't know what is required in your environment.
|
@rbaumgar, is the 9092 case actually, where a namespace parameter is required...which is not supported by jaeger SPM as the moment right ? |
@hkailantzis correct! I don't want to use a cluster role for SPM... |
@yurishkuro, I want to try it out |
If I understand the issue correctly, we want to send extra paramters to the promethes endpoint, right? I checked the documentation but couldn't find any such server-side handling for such extra parameters. Are you trying to use a proxy in between? Moreover, the current implementation uses prometheus client library instead of directly calling the http route, which only allows the paramters |
@akstron we pass |
I see, that makes sense. I will start working on it. Thanks! |
@akstron we should only do this in Jaeger v2 (i.e. don't both with v1 CLI flags for these headers). |
Requirement
I am using a global prometheus for spm where I need to add a specific query parameter to get data.
Currently no parameter is available to define an additional query parameter.
I only found --query.base-path which does not fit.
Problem
spm sends only e.g. "/api/v1/query?query=up", but I need to send "/api/v1/query?query=up&mykey=myvalue"
otherwise I don't get any data.
Proposal
please provide another parameter, eg. --query.additional-parameter.
Open questions
No response
The text was updated successfully, but these errors were encountered: