Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: v2 all-in-one binary cannot find sampling strategies file #6338

Open
duzunov opened this issue Dec 11, 2024 · 7 comments · May be fixed by #6356
Open

[bug]: v2 all-in-one binary cannot find sampling strategies file #6338

duzunov opened this issue Dec 11, 2024 · 7 comments · May be fixed by #6356
Labels
bug good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement v2

Comments

@duzunov
Copy link

duzunov commented Dec 11, 2024

Requirement

As a developer using jeager on my machine,

I would like a convenient non-docker all-in-one build for 2.x like we have in 1.x

Problem

Being able to quickly start using jeager without requiring Docker

Proposal

A non-docker all-in-one build for 2.x like we have in 1.x

Open questions

No response

@dosubot dosubot bot added the v2 label Dec 11, 2024
@jkowall
Copy link
Contributor

jkowall commented Dec 11, 2024

I do not understand why you do not want to use docker? Can you explain please?

@duzunov
Copy link
Author

duzunov commented Dec 11, 2024

None of our team uses docker, we have a simple architecture (single runtime, no microservices, etc) for which docker is unnecessary. We do use OTEL, though.

@jkowall
Copy link
Contributor

jkowall commented Dec 11, 2024

You can use the jaeger binary with the all in one config file to accomplish the same outcome: https://github.com/jaegertracing/jaeger/blob/main/cmd/jaeger/internal/all-in-one.yaml

@yurishkuro
Copy link
Member

No config is needed for all in one, just run the binary.

@duzunov
Copy link
Author

duzunov commented Dec 12, 2024

When I run ./jaeger from the jaeger-2.1.0-darwin-arm64 build I get this:

Error: failed to start extensions: failed to create the local file strategy store: failed to read strategies file ./cmd/jaeger/sampling-strategies.json: open cmd/jaeger/sampling-strategies.json: no such file or directory 2024/12/12 22:32:48 failed to start extensions: failed to create the local file strategy store: failed to read strategies file ./cmd/jaeger/sampling-strategies.json: open cmd/jaeger/sampling-strategies.json: no such file or directory

@duzunov
Copy link
Author

duzunov commented Dec 12, 2024

seems like it has some docker paths hardcoded

@yurishkuro
Copy link
Member

yes, this is an issue. It's a mistake to hardcode the local path cmd/jaeger/sampling-strategies.json in the embedded all-in-one config. It happens to work in Docker because we include this file, but the file itself is rather pointless (with two fake services), we should make Jaeger work without it in the default configuration.

@yurishkuro yurishkuro reopened this Dec 12, 2024
@yurishkuro yurishkuro changed the title [Feature]: [bug]: v2 all-in-one binary cannot find sampling strategies file Dec 12, 2024
@yurishkuro yurishkuro added help wanted Features that maintainers are willing to accept but do not have cycles to implement good first issue Good for beginners labels Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Good for beginners help wanted Features that maintainers are willing to accept but do not have cycles to implement v2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants