Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create v2 QueryService #6337

Open
yurishkuro opened this issue Dec 11, 2024 · 0 comments
Open

Create v2 QueryService #6337

yurishkuro opened this issue Dec 11, 2024 · 0 comments

Comments

@yurishkuro
Copy link
Member

The components of /cmd/query all depend on a QueryService which is a higher level abstraction that spanstore.Reader as it performs post-query adjustments on the trace before it is returned to the client.

In order to upgrade all the components in query to V2 Storage API we need to create a QueryServiceV2 that will operate on OTLP data instead of legacy model.Span.

The proposal is:

  • clone QueryService and update to OTLP data model
  • change query app to instantiate both of these structs temporarily
  • then we can start upgrading the endpoint handlers to work with QueryServiceV2, starting with apiv3 handler which already operates on OTLP and thus would require minimal changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant