Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger-v2][storage] Add Configuration For ClickHouse #6154

Open
mahadzaryab1 opened this issue Nov 3, 2024 · 4 comments
Open

[jaeger-v2][storage] Add Configuration For ClickHouse #6154

mahadzaryab1 opened this issue Nov 3, 2024 · 4 comments

Comments

@mahadzaryab1
Copy link
Collaborator

mahadzaryab1 commented Nov 3, 2024

As a first step in adding support for ClickHouse, we want to define the configuration that Jaeger will expose for users to create a connection to ClickHouse. The configurable options can be viewed here.

@mahadzaryab1
Copy link
Collaborator Author

mahadzaryab1 commented Nov 3, 2024

@yurishkuro thoughts on if we should be using the native clickhouse interface through go-clickhouse or the standard database/sql package in Go to connect to clickhouse (ref: https://clickhouse.com/docs/en/integrations/go#clickhouse-go-client).

@mahadzaryab1 mahadzaryab1 changed the title [jaeger-v2][storage]Add Configuration For ClickHouse [jaeger-v2][storage] Add Configuration For ClickHouse Nov 3, 2024
@yurishkuro
Copy link
Member

I don't have an opinion, did not research this question. Note that we already have an implementation in #4941

@haanhvu
Copy link
Contributor

haanhvu commented Dec 10, 2024

@yurishkuro thoughts on if we should be using the native clickhouse interface through go-clickhouse or the standard database/sql package in Go to connect to clickhouse (ref: https://clickhouse.com/docs/en/integrations/go#clickhouse-go-client).

I thought of this when doing #4941 too. The reason I chose database/sql back then was because OTel ClickHouse exporter used it, and this exporter had been widely used and tested by the community: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/exporter/clickhouseexporter

@yurishkuro
Copy link
Member

According to the docs the sql/database API is the least performant of the three APIs, so we should avoid it. It would be interesting to see how more complicated the ch-go usage would be, as that's the most performant way, but the middle ground with clickhouse-go is probably ok.

Another option is to use ch-go for writing and clickhouse-go for reading.

Cc @mahadzaryab1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants