addiing parallelism to speed up performace issue #6111 #6139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… logger.go LogMatcher function Signed-off-by: Insomniac2904 <[email protected]>
fix function name in comment Signed-off-by: cangqiaoyuzhuo <[email protected]> Signed-off-by: Insomniac2904 <[email protected]>
## Which problem is this PR solving? The `component.UseLocalHostAsDefaultHost` gate has been removed from otel collector since v0.112.0. The example failed to start `jaeger` because of the invalid argument. ## Description of the changes - Remove the invalid command line argument. - Set endpoints for `otlpreceiver` explicitly. ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: haoqixu <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Insomniac2904 <[email protected]>
Insomniac2904
force-pushed
the
parallelism-on-test
branch
from
540e45f to
393a43b
Compare
yurishkuro
reviewed
Oct 29, 2024
| var LogMatcher = func(occurrences int, subStr string, logs []string) (bool, string) { | ||
| errMsg := fmt.Sprintf("subStr '%s' does not occur %d time(s) in %v", subStr, occurrences, logs) | ||
| if len(logs) < occurrences { | ||
| return false, errMsg | ||
| } | ||
|
|
||
| // Count occurrences in parallel |
There was a problem hiding this comment.
Initially I thought that as log volume increases , concurrent checking for the occurrences would help. But now that I checked the function calls I see that none of the calls affect the testing time of the command that was mentioned in the issue. I have removed the changes to my code locally . Should I submit a new PR? Are there any more changes that I need to do ?
Thanks.
|
Please read the ticket description carefully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
t.parallel()in test functions and used goroutines for checking occurrences in LogMatcher function.How was this change tested?
GOMAXPROCS=1 go test -parallel 128 -p 16 -json ./... | go run github.com/roblaszczak/vgt@latestChecklist
jaeger:make lint testjaeger-ui:yarn lintandyarn testResults