Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jaeger-v2] Align Kafka Config With OTEL #6002

Closed
6 tasks
mahadzaryab1 opened this issue Sep 20, 2024 · 1 comment
Closed
6 tasks

[jaeger-v2] Align Kafka Config With OTEL #6002

mahadzaryab1 opened this issue Sep 20, 2024 · 1 comment

Comments

@mahadzaryab1
Copy link
Collaborator

mahadzaryab1 commented Sep 20, 2024

Requirement

In this issue, we want to align the configuration for kafka with OTEL (part of #5229)

Tasks / outcomes

  • All config fields are tagged with mapstructure such that they can be addressable from YAML via "good" names
  • Configs implement Validate()
  • Configs via YAML support the same defaults as in jaeger-v1
  • Configs reuse standard elements of OTEL configs whenever possible, e.g. TLS, clientcfg, etc.
  • Configuration looks "logical" and properly grouped, not flattened with long weird names
  • We create a migration guide document with a table that lists v1 CLI flags and the corresponding v2 config fields
@mahadzaryab1
Copy link
Collaborator Author

We are using upstream kafka exporter and receiver from open telemetry already, so nothing needs to be done here.

@yurishkuro yurishkuro reopened this Sep 22, 2024
@yurishkuro yurishkuro closed this as not planned Won't fix, can't repro, duplicate, stale Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants