-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jaeger-operator] Added config to make operator watch in arbitrary namespaces #109
base: main
Are you sure you want to change the base?
[jaeger-operator] Added config to make operator watch in arbitrary namespaces #109
Conversation
606eacd
to
51258ec
Compare
Setting So I guess this PR should only be merged once that bug got fixed. |
@davelosert can you update this PR? so we can finish the review and merge. If this makes no sense anymore feel free to close it |
51258ec
to
30c2267
Compare
Signed-off-by: David Losert <[email protected]>
30c2267
to
9b99bc9
Compare
@cpanato : Updated the PR and adjusted the version. Should be ready for merge now 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What's keeping this PR from getting merged? I'm currently experiencing an issue with the namespaces and I think this could fix it. |
Any updates? |
I'm not sure the logic here is correct, nor is it correct currently either, as setting |
The current helm-chart only allows a somewhat "all or nothing" strategy when it comes to RBAC and watching namespaces: Either the operator only has rights and watches the namespace it was deployed to or it has cluster-wide permissions with a
ClusterRoleBinding
.This PR introduces a configuration to watch for arbitrary namespaces.
If set, it also creates a
ClusterRole
, but onlyRoleBindings
in all defined namespaces.