Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISOTime #16

Open
pahjbo opened this issue Apr 14, 2023 · 2 comments
Open

ISOTime #16

pahjbo opened this issue Apr 14, 2023 · 2 comments

Comments

@pahjbo
Copy link
Member

pahjbo commented Apr 14, 2023

The description of ISOTime says that the string representation follows FITS and drops the final Z that indicates UTC. I thought that this error had been corrected (and accepted) in the IVOA quite a long time ago. If something looks like an ISO time, is called an ISO time then it should follow the ISO rules. If you pass the bare time string to an iso time interpreting library on your computer then it will return a local time - which will possibly be incorrect depending on location and computer timezone setup

@pahjbo
Copy link
Member Author

pahjbo commented Dec 14, 2023

if the string representation definition is to be kept then it should be called FITSTime

@mcdittmar
Copy link
Collaborator

mcdittmar commented Dec 15, 2023 via email

pahjbo added a commit to Javastro/CoordinateDM that referenced this issue Jan 4, 2024
These updates address several issues
* ivoa-std#4
* ivoa-std#16
* and the discussion around Quantity where it does not have a "value" defined mean that for practical source generation a cartesian point with a real quantity is needed

IVOA base version 1.1 - potential for better unit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants