Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protection against multiple concurrent usages was broken to never allow restarting. This change is pretty significant, but also simple.
LighthouseState
is no longer a member variable, instead a new state is created on each call toLighthouseClient.discoverDevices()
.shouldPersist
is no longer possible to implement. If that feature is required, an existing list could be passed todiscoverDevices
.I removed
DiscoveryManager
. It didn't actually manage anything anymore. The two helper functions from there made more sense as part ofRealLighthouseClient
.Fixes #31