Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CX SQL_Injection @ server/server.js [main] #22

Open
itsKedar opened this issue Jul 26, 2022 · 1 comment
Open

CX SQL_Injection @ server/server.js [main] #22

itsKedar opened this issue Jul 26, 2022 · 1 comment

Comments

@itsKedar
Copy link
Owner

itsKedar commented Jul 26, 2022

SQL_Injection issue exists @ server/server.js in branch main

*The application's app.patch method executes an SQL query with CxAssociativeArray_95b444c4, at line 48 of server\server.js. The application constructs this SQL query by embedding an untrusted string into the query without proper sanitization. The concatenated string is submitted to the database, where it is parsed and executed accordingly.
An attacker would be able to inject arbitrary syntax and data into the SQL query, by crafting a malicious payload and providing it via the input complete; this input is then read by the app.patch method at line 49 of server\server.js. This input then flows through the code, into a query and to the database server - without sanitization.
This may enable an SQL Injection attack.

The application's app.delete method executes an SQL query with id, at line 42 of server\server.js. The application constructs this SQL query by embedding an untrusted string into the query without proper sanitization. The concatenated string is submitted to the database, where it is parsed and executed accordingly.
An attacker would be able to inject arbitrary syntax and data into the SQL query, by crafting a malicious payload and providing it via the input id; this input is then read by the app.delete method at line 42 of server\server.js. This input then flows through the code, into a query and to the database server - without sanitization.
This may enable an SQL Injection attack.

The application's app.patch method executes an SQL query with id, at line 48 of server\server.js. The application constructs this SQL query by embedding an untrusted string into the query without proper sanitization. The concatenated string is submitted to the database, where it is parsed and executed accordingly.
An attacker would be able to inject arbitrary syntax and data into the SQL query, by crafting a malicious payload and providing it via the input id; this input is then read by the app.patch method at line 48 of server\server.js. This input then flows through the code, into a query and to the database server - without sanitization.
This may enable an SQL Injection attack.
*

Severity: High

CWE:89

Checkmarx

Training
Recommended Fix

Lines: 48 49 42


Code (Line #48):

  Todo.findByIdAndUpdate(req.params.id, {

Code (Line #49):

    complete: req.body.complete,

Code (Line #42):

  Todo.findByIdAndDelete(req.params.id)

@itsKedar
Copy link
Owner Author

itsKedar commented Aug 1, 2022

Issue still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant