Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack v5 support #21

Open
burt202 opened this issue Aug 6, 2021 · 7 comments
Open

Webpack v5 support #21

burt202 opened this issue Aug 6, 2021 · 7 comments

Comments

@burt202
Copy link
Collaborator

burt202 commented Aug 6, 2021

Hi,

It'll be good for this plugin to support webpack v5. In the meantime Ive forked/rewritten it here https://github.com/burt202/nunjucks-webpack-plugin for anyone that wants v5 support sooner. It also simplifies the code and massively reduces (and updates) all dependencies

Cheers

@Jakobud
Copy link

Jakobud commented Feb 3, 2022

@alexander-akait would it be possible to incorporate these improvements into this repo so that Webpack 5 is supported? Or would it be possible to pass the ownership/responsibility of this repository to someone who could update it and publish to NPM?

@alexander-akait
Copy link
Member

Sorry, I don't have time on this package, I can give permissions for this repo and npm

@burt202
Copy link
Collaborator Author

burt202 commented Feb 4, 2022

Im happy to take this on if you like. Let me know what I need to do

@alexander-akait
Copy link
Member

sent invite

@burt202
Copy link
Collaborator Author

burt202 commented Feb 4, 2022

Ok cool, i wont do anything immediately but I'll likely just override the whole repo with the code in the fork and then publish a v6. Ill keep the license and changelog bits though.

Also its worth noting, my fork doesnt port across all features, so I would be tempted to fix forward and see what people miss as time goes on.

How does that sound? Everyone happy with that?

@alexander-akait
Copy link
Member

Yep, feel free to send PRs, I will review

@burt202
Copy link
Collaborator Author

burt202 commented Feb 7, 2022

Ive just brought over the tests into my fork and one of them fails due to changes with webpack between v4 and v5 (to do with compilation.hash). I havent got time right now to look into this Im afraid but hopefully I can find some time soon to complete this update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants