HTML Object Return - Add option to return html un-stringified (for use in libraries/plugins) #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For libraries and plugin authors using this downstream, this adds an option to get the html as objects that allow independently tracking the tags and their attributes.
|
Other option would be to expand export interface FaviconResponse {
readonly images: FaviconImage[];
readonly files: FaviconFile[];
readonly html: FaviconHtmlElement[]; // string[]
readonly htmlTags: FaviconHtmlTag[];
}Then use |
|
That's kind of what I have it doing. But the different return type means that if you're using the un-stringified return, the stringification doesn't even have to run. |
|
Okay, the additional return did simplify things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #442
In other libraries/plugins, it's necessary to separately apply tag data and/or add their own, while still mostly following what
faviconssupplies.It took more modification than I'd like to get all the types to return based on the options, but I seem to have got it right, all the tests pass (even made sure the tag order is the same so the snapshots pass), and the return types behave as I'd expect.