Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved WebDAV authentication #6418

Closed
wants to merge 1 commit into from

Conversation

JojoDevel
Copy link

The following environment variables can now be used for WebDAV authentication:

  • WEBDAV_USER: to specify the username
  • WEBDAV_PASSWORD: to specify the password of the user

Closes iterative/dvc-webdav#16
WebDAV documentation should be updated #6417

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

- added environment variable based authentication
@JojoDevel JojoDevel requested a review from a team as a code owner August 12, 2021 06:58
@JojoDevel JojoDevel requested a review from pared August 12, 2021 06:58
Copy link
Contributor

@pared pared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good if we had a test verifying it is working as intended.

Is providing WEBDAV_USER and WEBDAV_PASSWORD some kind of standard, or would it be only in dvc?

@efiop efiop requested a review from skshetry August 12, 2021 10:27
@skshetry
Copy link
Member

Please see the discussion here: iterative/dvc-webdav#16.

@efiop efiop added the awaiting response we are waiting for your reply, please respond! :) label Aug 22, 2021
@skshetry
Copy link
Member

skshetry commented Aug 25, 2021

Hi, @JojoDevel. I understand that the environment variable would improve usability in the CI, but I'd like to wait for more interest on this stuff and don't want to commit to the environment variables yet.
I'd suggest you set global config or use .netrc as a workaround for now. Thanks for contributing. 🙂

Closing the PR ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response we are waiting for your reply, please respond! :)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebDAV authentication using environment variables
4 participants