Skip to content
This repository has been archived by the owner on Jul 2, 2021. It is now read-only.

Duplicated quickfix for missing visibillity #282

Open
Mazesch opened this issue Aug 1, 2019 · 1 comment
Open

Duplicated quickfix for missing visibillity #282

Mazesch opened this issue Aug 1, 2019 · 1 comment
Assignees
Labels

Comments

@Mazesch
Copy link
Collaborator

Mazesch commented Aug 1, 2019

The suggestion for the following code(which is missing a visibillity) is
"Make this function 'external'"
"Make this function 'external'"

although the visibillity should be 'public' or 'internal';
note that one of the quickfixes disappears after you remove Contract1

code example:

pragma solidity ^0.5.4;

contract Contract1 {
}

contract Contract2 {
    constructor ()  {}
}
@jthoene
Copy link
Collaborator

jthoene commented Aug 6, 2019

The duplication of the quickfix seems to be caused by the validator. The error also appears two times in the problems view. Would be good if @flantony also takes a look at this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants