cflags etsi codecs: -m32

[skinkie]

-m32 isn't available on all platforms, thus fails on ARM for example. I would also suggest to add -march=native for better optimisation.

[rumo333]

dark@dark-HP-ZBook-15:~/tetra-listener$ ./build.sh
en_30039502v010301p0.zip: OK
en_30039502v010301p0.zip: OK
Archive: en_30039502v010301p0.zip
inflating: c-word/c_word.win
inflating: c-word/c_word_a.doc
inflating: c-word/c_word_b.doc
inflating: c-word/c_word_c.doc
inflating: c-word/c_word_d.doc
inflating: c-word/c_word_e.doc
inflating: c-word/c_word_f.doc
inflating: amr-code/arrays.h
inflating: amr-code/arrays.tab
inflating: amr-code/arrays_amr475.tab
inflating: amr-code/arrays_tetra.tab
inflating: amr-code/ccoder.c
inflating: amr-code/ccod_tet.c
inflating: amr-code/cdecoder.c
inflating: amr-code/cdec_tet.c
inflating: amr-code/channel.h
inflating: amr-code/const.tab
inflating: amr-code/const_amr475.tab
inflating: amr-code/const_tetra.tab
inflating: amr-code/globals.c
inflating: amr-code/globals.h
inflating: amr-code/init_params.c
inflating: amr-code/makefile
inflating: amr-code/source.h
inflating: amr-code/sub_cc.c
inflating: amr-code/sub_cd.c
inflating: amr-code/tetra_op.c
inflating: c-code/arrays.tab
inflating: c-code/ccoder.c
inflating: c-code/ccod_tet.c
inflating: c-code/cdecoder.c
inflating: c-code/cdec_tet.c
inflating: c-code/channel.h
inflating: c-code/clsp_334.tab
inflating: c-code/const.tab
inflating: c-code/ener_qua.tab
inflating: c-code/fbas_tet.c
inflating: c-code/fexp_tet.c
inflating: c-code/fmat_tet.c
inflating: c-code/grid.tab
inflating: c-code/inv_sqrt.tab
inflating: c-code/lag_wind.tab
inflating: c-code/log2.tab
inflating: c-code/makefile
inflating: c-code/pow2.tab
inflating: c-code/scoder.c
inflating: c-code/scod_tet.c
inflating: c-code/sdecoder.c
inflating: c-code/sdec_tet.c
inflating: c-code/source.h
inflating: c-code/sub_cc.c
inflating: c-code/sub_cd.c
inflating: c-code/sub_dsp.c
inflating: c-code/sub_sc_d.c
inflating: c-code/tetra_op.c
inflating: c-code/window.tab
patching file amr-code/makefile
patching file c-code/makefile
patching file amr-code/source.h
patching file c-code/source.h
patching file amr-code/channel.h
patching file amr-code/source.h
Hunk #1 succeeded at 165 (offset 1 line).
patching file amr-code/tetra_op.c
patching file c-code/channel.h
patching file c-code/source.h
Hunk #1 succeeded at 165 (offset 1 line).
patching file c-code/sub_dsp.c
patching file c-code/sub_sc_d.c
patching file c-code/tetra_op.c
patching file amr-code/init_params.c
patching file c-code/cdecoder.c
patching file c-code/sdecoder.c
patching file c-code/makefile
Hunk #1 FAILED at 23.
1 out of 1 hunk FAILED -- saving rejects to file c-code/makefile.rej
patching file amr-code/makefile
Hunk #1 FAILED at 21.
1 out of 1 hunk FAILED -- saving rejects to file amr-code/makefile.rej

anyone know how to repair that?

[skinkie]

@rumo333 this is not related to the ticket. Could you open a new issue?

[smarek]

Well it is related, patch that fails is the one introducing m32 CFLAGS, for some reason repository included patch expects

I've commited changes that fix the issue in my environment, and use march=native as per @skinkie request

Could you please test and close this issue if appropriate?

[skinkie]

Thanks for following this up.

[ericek111]

I'm just getting into TETRA decoding. Check out this patch: https://raw.githubusercontent.com/sq5bpf/install-tetra-codec/master/codec.diff

Found in https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=tetra-codec - compiles out of the box on Arch Linux.

[smarek]

@ericek111 our current patch-set includes more than what's in aur, specifically patches for marking timeslots and U/D patches, why did you send link to patches into this ticket, is it somehow related?

[ericek111]

Since this issue is still open, I left it here as a reference. According to some other threads and bug reports, the ETSI codec fails to compile without -m32.

The linked patch does some refactoring and the AUR package compiles fine for me. I don't yet fully understand how every link of the chain works.