Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round calculators constructor results to 2 decimal places #986

Merged

Conversation

olexandervanzuriak
Copy link
Contributor

@olexandervanzuriak olexandervanzuriak commented Nov 28, 2024

#978

Code reviewers

Summary of issue

Add rounding to calculators constructor the results of calculations to 2 decimal places

Summary of change

Added round to calculation_service results

Video.mp4

Testing approach

Tested locally

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

…cts/ZeroWaste into 978-rounding-results-to-2-decimal-places
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.74%. Comparing base (f934abb) to head (3303bac).
Report is 19 commits behind head on calculators-constructor.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           calculators-constructor     #986   +/-   ##
========================================================
  Coverage                    86.74%   86.74%           
========================================================
  Files                           68       68           
  Lines                         1056     1056           
========================================================
  Hits                           916      916           
  Misses                         140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@loqimean loqimean merged commit bd339de into calculators-constructor Dec 4, 2024
7 checks passed
@loqimean loqimean deleted the 978-rounding-results-to-2-decimal-places branch December 4, 2024 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants