Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload the calculator logo #982

Open
wants to merge 10 commits into
base: calculators-constructor
Choose a base branch
from

Conversation

KseniaGovorun
Copy link

@KseniaGovorun KseniaGovorun commented Nov 26, 2024

dev

Code reviewers

Summary of issue

The user should be able to upload the calculator logo

Summary of change

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • PR meets all conventions
    image
    image
    image

@KseniaGovorun KseniaGovorun self-assigned this Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.77%. Comparing base (f934abb) to head (e3a6762).

Additional details and impacted files
@@                     Coverage Diff                     @@
##           calculators-constructor     #982      +/-   ##
===========================================================
+ Coverage                    86.74%   86.77%   +0.03%     
===========================================================
  Files                           68       68              
  Lines                         1056     1059       +3     
===========================================================
+ Hits                           916      919       +3     
  Misses                         140      140              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KseniaGovorun KseniaGovorun force-pushed the 970-ability-upload-logo branch from e4b6ed9 to 4f47f52 Compare December 2, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant