Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

935 sign in via google #952

Merged
merged 2 commits into from
Dec 1, 2024
Merged

935 sign in via google #952

merged 2 commits into from
Dec 1, 2024

Conversation

NVMakarenko
Copy link
Contributor

@NVMakarenko NVMakarenko commented Nov 14, 2024

dev

PROJECT

Code reviewers

Second Level Review

Summary of issue

Add possibility to sign in with Google-account for Admin

Summary of change

Added possibility to sign in with Google-account for Admin

google_auth.mp4

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

!!! Final step

Need to add google_client_id and google_client_secret into credentials.yml.enc

@loqimean loqimean merged commit c2f816b into develop Dec 1, 2024
5 checks passed
@loqimean loqimean deleted the 935-sign-in-via-google branch December 1, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sign in] via Google account.
3 participants