Add formula relations to calculators constructor #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## calculators-constructor #1006 +/- ##
===========================================================
+ Coverage 87.07% 87.33% +0.26%
===========================================================
Files 68 69 +1
Lines 1060 1082 +22
===========================================================
+ Hits 923 945 +22
Misses 137 137 ☔ View full report in Codecov by Sentry. |
loqimean
reviewed
Jan 3, 2025
Comment on lines
+2
to
+3
| <%= image_tag "icons/vector_5.png", class: locals[:rotate_direction], alt: "horizontal arrow" %> | ||
| <%= image_tag "icons/vector_2.png", class: "vector-mobile-#{locals[:rotate_direction]}", alt: "vertical arrow" %> |
There was a problem hiding this comment.
я використав стрілку з diapers calculator лиш додав ще стрілку в інший бік
| @@ -6,7 +6,7 @@ | |||
| let(:calculator) { instance_double("Calculator", formulas: formulas) } | |||
| let(:formulas) do | |||
| [ | |||
| Formula.new(en_label: "Addition", en_unit: "units", uk_label: "Додавання", uk_unit: "одиниці", expression: "x + y"), | |||
| Formula.new(en_label: "Addition", en_unit: "units", uk_label: "Додавання", uk_unit: "одиниці", expression: "x + y", relation: "next"), | |||
There was a problem hiding this comment.
чому саме next? що мається наувазі?
| @@ -9,6 +9,8 @@ | |||
|
|
|||
| <%= f.input :uk_unit, label: "Uk Unit Label:" %> | |||
| <%= f.input :en_unit, label: "Unit Label:" %> | |||
| <%= f.input :relation, as: :select, label: "Relation of formula (optional):", | |||
| collection: { "None": nil, "Next": "next", "Previous": "previous"}, default: "None" %> | |||
There was a problem hiding this comment.
you should relate it to specific formula, not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#989
Code reviewers
Summary of issue
Add relation to calculators constructor so that they looks similar to dippers calculator relations
Result
Added select input field on creating calculator constructor
Video.mp4
Results on show page
Video2.mp4
Summary of change
Added relation field to formula model and validations for it
CHECK LIST