nyc fails with "Unexpected token ILLEGAL" when execing shell script

[boennemann]

As first reported via https://twitter.com/boennemann/status/619103847043203072

I'm trying to instrument the integration tests for https://github.com/semantic-release/semantic-release.
They are running a shell script to start the npm-registry-couchapp before tap/nixt tests are running against it. Everything works fine, but once I run them with nyc I get this error (multiple times):

[eval]:1
/private/tmp/node-spawn-wrap-17602-9d862ee799ec/node
                                   ^
SyntaxError: Unexpected token ILLEGAL
    at Object.exports.runInThisContext (vm.js:53:16)
    at Object.<anonymous> ([eval]-wrapper:6:22)
    at Module._compile (module.js:426:26)
    at node.js:567:27
    at doNTCallback0 (node.js:408:9)
    at process._tickCallback (node.js:337:13)

Steps to reproduce:

git clone [email protected]:semantic-release/semantic-release.git
cd semantic-release
git fetch origin  next:next
git checkout next
npm install
npm run build && npm run test:build
npm run test:unit # nyc built in, passes and reports coverage
npm run test:integration # passes
nyc npm run test:integration # fails

You need couchdb installed. Sorry for the bloated test case, will try to reduce it if this doesn't get you anywhere.

The relevant script is here: https://github.com/semantic-release/semantic-release/blob/next/test/registry/start.sh
Which gets execd here: https://github.com/semantic-release/semantic-release/blob/next/test/registry/index.js#L9

[bcoe]

CC: @isaacs

[bcoe]

@boennemann haven't forgotten about this issue, but have been absolutely swamped lately. The most likely source of this issue is probably going to be somewhere in:

https://github.com/isaacs/spawn-wrap

Thanks for the test case, will dig into this as soon as I pop a few things off my stack.

[bcoe]

@boennemann hope the semantic-release project is going well, I really liked hearing about the project at NodeConf Adventure.

[boennemann]

@bcoe Thanks for the update! I absolutely understand that things take their time 👍
I've updated the original post, because the repo location changed.

Also thank you for the kind words 😊 Things are shaping up nicely and talking to you and the other npm folks directly helped a lot with it!

[bcoe]

@boennemann finally dug into this issue, see:

istanbuljs/spawn-wrap#10

By simply ignoring start.sh in spawn-wrap, I was able to run your integration tests:

[bcoe]

@boennemann could you create an up-to-date reproduction of this issue? @addaleax offered to help dig into the issue.

Alternatively, if everything is working well now perhaps we can close this?

[bcoe]

@boennemann feel free to reopen if you bump into this again, or have a chance to dust off this old issue.