Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track List/Map/Model data Varyings without making refs #145

Open
issa-tseng opened this issue Mar 21, 2019 · 0 comments
Open

Track List/Map/Model data Varyings without making refs #145

issa-tseng opened this issue Mar 21, 2019 · 0 comments
Labels
enhancement internals

Comments

@issa-tseng
Copy link
Owner

Right now to make janus-inspect work, we drop a reference to the parent data structure onto the generated Varying when we create a captive Varying (eg list.length or map.get('key')).

But refs scare me. I don't like refs. Is there another option?
issa-tseng added a commit that referenced this issue Mar 26, 2019
@issa-tseng
collection/new: mark owner on List/Map get/length Varyings for inspect.
22bbb3c 
* i dislike this solution immensely.
* see #145 for why.
* but it's all i can think of for now.
* and though i'm fuzzy on it i do think the GC works out?
issa-tseng added a commit that referenced this issue Jul 25, 2019
@issa-tseng
collection/new: mark owner on List/Map get/length Varyings for inspect.
de82a86 
* i dislike this solution immensely.
* see #145 for why.
* but it's all i can think of for now.
* and though i'm fuzzy on it i do think the GC works out?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement internals
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@issa-tseng