Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: issues with alertUnfinished #3586

Open
gweinberg opened this issue Dec 26, 2024 · 0 comments
Open

[Bug]: issues with alertUnfinished #3586

gweinberg opened this issue Dec 26, 2024 · 0 comments
Labels

Comments

@gweinberg
Copy link

gweinberg commented Dec 26, 2024

Description

When clicking "finish lesson", there are three issues I find when pressing the button; although note, this is only as an instructor, although I can confirm these issues in presentation mode; if these issues are not also present for students let me know:

Note, this is on https://isle.stat.cmu.edu/36-200-spring25/lab3/ , when I enter no answers and simply scroll down and press the "finish lesson" button (although as an instructor, but confirmed in presentation mode), and the code contains alertUnfinished={true}:

  1. I was under the impression that it alerted if some questions were unanswered, however it appears that the alert actually says that the answer is "incorrect" rather than "missing."

  2. I was under the impression that if a question was unanswered, then the alertUnfinished={true} should say something like, "are you sure you want to submit anyway?" but (at least for me) no such notification appears.

  3. Despite the "incorrect" flags, it also gives a "lesson successfully completed, download pdf of responses" flag and an email confirmation that the lesson has been successfully completed.

  4. If the student submits the lesson with some answers blank (even after what I thought was the intended functionality of the lesson alerting to un-finished questions and giving the option to submit anyway), the resulting notification should not say that the lesson has been "successfully completed," since the student will then wrongly think they will recieve 100% (when, in fact, their completion percentage in the instructor panel will show less than 100% and that is what their grade for the assignment will be based on).

Expected behavior

  1. for a missing answer, it should say "missing" rather than "incorrect," and I was under the impression that it said something like, "an answer is missing, do you want to submit anyway?"

  2. If an answer is missing, it shouldn't also pop up "completed, download pdf of responses"

  3. If what I had thought was the intended functionality is restored (if an answer is missing, student presses "finish lesson" and gets an alert that an answer is missing, and an option to "submit anyway"), then if the student chooses "submit anyway" (with a missing answer), the pop up and email notifications should not say that the lesson has been "successfully completed"

To Reproduce

go to https://isle.stat.cmu.edu/36-200-spring25/lab3/ -> leave the entire lesson blank -> scroll down and press "finish lesson"

Version

0.76.23

Link to ISLE lesson

https://isle.stat.cmu.edu/36-200-spring25/lab3/

ISLE Code

No response

What browsers are you seeing the problem on?

Firefox

What browser version?

133.0.3

Additional context

No response

@gweinberg gweinberg added the bug label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant