Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orient_normals_consistent_tangent_plane method does not accept lambda as a valid argument #7106

Open
3 tasks done
Hennsie opened this issue Dec 19, 2024 · 2 comments
Open
3 tasks done
Labels
bug Not a build issue, this is likely a bug.

Comments

@Hennsie
Copy link

Hennsie commented Dec 19, 2024

Checklist

Describe the issue

Attempting to use the orient_normals_consistent_tangent_plane method in Open3D, the function does not recognize lambda as a valid argument name.

Steps to reproduce the bug

import numpy as np
import open3d as o3d
points = np.random.random((100,3))
pcd = o3d.geometry.PointCloud(o3d.utility.Vector3dVector(points))
pcd.estimate_normals()
pcd.orient_normals_consistent_tangent_plane(k=5, lambda=0.1)

Error message

SyntaxError: invalid syntax

Expected behavior

Just an other name for the argument lambda for example lambda_

Open3D, Python and System information

- Operating system: Ubuntu 22.04.5
- Python version: 3.10.12 (main, Nov  6 2024, 20:22:13) [GCC 11.4.0]
- Open3D version: 0.18.0
- System architecture: x86
- Is this a remote workstation?: yes
- How did you install Open3D?: pip

Additional information

No response

@Hennsie Hennsie added the bug Not a build issue, this is likely a bug. label Dec 19, 2024
@timohl
Copy link
Contributor

timohl commented Dec 19, 2024

Good catch, but I was faster. :D
I fixed it already in #7096 and it got merged yesterday. ;)

Thanks for reporting, though!

@timohl
Copy link
Contributor

timohl commented Dec 19, 2024

Oh, also as a workaround in 0.18.0 you can use the following:

pcd.orient_normals_consistent_tangent_plane(k=5, **{"lambda": 0.1})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not a build issue, this is likely a bug.
Projects
None yet
Development

No branches or pull requests

2 participants