-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stackSentinel background task fix #271
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this specific PR, but I would suggest to simplify write_wrapper_config2run_file()
by:
- set default
line_cnt=1
- change
if line_cnt == numProcess
toif line_cnt % numProcess == 0
In this way, the input line_cnt is the actual line index, so we don't need to return this variable, thus, shorten all calls of the func from:
line_cnt = configObj.write_wrapper_config2run_file(configName, line_cnt)
to
configObj.write_wrapper_config2run_file(configName, line_cnt)
@yunjunz I would be happy to change
to
in the three occurrences. I left as above as it might be simpler to follow. Presently the stackSentinel.py |
Thank you for getting back to this @RussellGrew. Could you do the following?
I would prefer the latter one. We don't need to show the details if we don't have to. |
@yunjunz I think that is everything. |
These two still stand I believe:
|
That should be much closer. You did this to yourself with your notes of encouragement on https://mintpy.readthedocs.io/en/latest/#5_contributing I see the CI has now passed. I am not familiar with these new ionosphere steps. I checked that the config is written out, and that step 17 and 18 which consider the Cheers. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you @RussellGrew!
There is a problem with #223 in which any tasks running in the background will continue in the background when the next step of the process begins (eg: run_03 can bleed into run_04). This causes issues when some steps try and use incomplete data.
The proposed solution writes a final
wait
in any shell scripts which leveragenum_process
.I welcome any feedback.