Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll through diff #63

Open
tinybeachthor opened this issue Jan 17, 2019 · 6 comments
Open

scroll through diff #63

tinybeachthor opened this issue Jan 17, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@tinybeachthor
Copy link

when viewing complete diff of a commit, it's not possible to scroll

@isacikgoz
Copy link
Owner

Hi @WhoMeNope thanks for the feedback, it is possible to navigate throguh diff via pg up/pg down. I tihnk I should add those to bottom line.

@isacikgoz
Copy link
Owner

fixed with #68

@tinybeachthor
Copy link
Author

tinybeachthor commented Jan 18, 2019

The keyboard I'm using does not have pg up/pg down.

Perhaps also implementing / (full page forward/full page backwards) and / (half page down, half page up) would be nice, to keep it consistent with vim.

@isacikgoz
Copy link
Owner

@WhoMeNope are you using macbook? pg up/down is mapped to fn+up/down combination.

@tinybeachthor
Copy link
Author

That is still a cumbersome combination of keys as it requires to completely change the hand position on the keyboard (as basically anything involving arrow keys).

That's why j/k/control+d/control+u would be more practical for fast (and comfortable) workflow.

@isacikgoz
Copy link
Owner

@WhoMeNope got it, i will re-open this issue and add proper vim keybindings for page up/down.

  • c-B one screen up
  • c-F one screen down
  • c-U half screen up
  • c-D half screen down

@isacikgoz isacikgoz reopened this Jan 18, 2019
@isacikgoz isacikgoz added the enhancement New feature or request label Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants