Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cypress tests for portal/brand Providers section #2820

Open
wants to merge 3 commits into
base: bleeding
Choose a base branch
from

Conversation

R0MANDEV
Copy link
Contributor

Type Of Change

  • Small bug fix
  • New feature or enhancement
  • Breaking change

Checklist:

  • Commits are named and have tag following commit rules
  • Commits are split per component (schema, portal/platform, kamusers, agis, ..)
  • Changes have been tested locally
  • Fixes an existing issue (Fixes #XXXX)
  • Upport from existing Pull request #XXXX

Description

Additional information

@R0MANDEV R0MANDEV changed the title hello :) tests: providers Nov 18, 2024
@Kaian Kaian changed the title tests: providers tests: Add cypress tests for portal/brand Providers section Nov 18, 2024
@Kaian Kaian changed the title tests: Add cypress tests for portal/brand Providers section Added cypress tests for portal/brand Providers section Nov 18, 2024
@R0MANDEV R0MANDEV force-pushed the PROVIDER-1959-tests-branded-session-providers branch 3 times, most recently from f8ce987 to 1e2d863 Compare November 26, 2024 09:49
@R0MANDEV R0MANDEV requested a review from danigargar November 26, 2024 09:54
@R0MANDEV R0MANDEV self-assigned this Nov 26, 2024
@R0MANDEV R0MANDEV added tests Test portal/brand Brand portal labels Nov 26, 2024
@R0MANDEV R0MANDEV force-pushed the PROVIDER-1959-tests-branded-session-providers branch 15 times, most recently from c90b3ad to 8519947 Compare December 3, 2024 09:12
@R0MANDEV R0MANDEV force-pushed the PROVIDER-1959-tests-branded-session-providers branch 5 times, most recently from 8de7484 to b894fcf Compare December 5, 2024 16:54
@R0MANDEV R0MANDEV force-pushed the PROVIDER-1959-tests-branded-session-providers branch 17 times, most recently from ab233e1 to 04132d3 Compare December 9, 2024 14:44
@R0MANDEV R0MANDEV force-pushed the PROVIDER-1959-tests-branded-session-providers branch 5 times, most recently from 36c723b to 5ab93c2 Compare December 9, 2024 15:58
@R0MANDEV R0MANDEV force-pushed the PROVIDER-1959-tests-branded-session-providers branch from 5ab93c2 to a7d9d6e Compare December 10, 2024 13:57
Comment on lines +66 to +74
const {
username,
realm,
authUsername,
authPassword,
authProxy,
expires,
multiDdi,
} = editDdisProvidersRegistrations.request;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const {
username,
realm,
authUsername,
authPassword,
authProxy,
expires,
multiDdi,
} = editDdisProvidersRegistrations.request;
const data = editDdisProvidersRegistrations.request;
delete domain;
delete data.contactUserName;
delete ddiProvider;

Just a suggestion. Don't you think it reads better this way? You know what you are skipping.
You may also just delete those fields from json fixture. What matters for pact files generation is whatever is actually posted.

@Kaian Kaian force-pushed the bleeding branch 2 times, most recently from df24ab3 to 842b736 Compare December 12, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
portal/brand Brand portal tests Test
Development

Successfully merging this pull request may close these issues.

2 participants