-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added cypress tests for portal/brand Providers section #2820
Open
R0MANDEV
wants to merge
3
commits into
bleeding
Choose a base branch
from
PROVIDER-1959-tests-branded-session-providers
base: bleeding
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kaian
changed the title
tests: providers
tests: Add cypress tests for portal/brand Providers section
Nov 18, 2024
Kaian
changed the title
tests: Add cypress tests for portal/brand Providers section
Added cypress tests for portal/brand Providers section
Nov 18, 2024
R0MANDEV
force-pushed
the
PROVIDER-1959-tests-branded-session-providers
branch
3 times, most recently
from
November 26, 2024 09:49
f8ce987
to
1e2d863
Compare
R0MANDEV
force-pushed
the
PROVIDER-1959-tests-branded-session-providers
branch
15 times, most recently
from
December 3, 2024 09:12
c90b3ad
to
8519947
Compare
R0MANDEV
force-pushed
the
PROVIDER-1959-tests-branded-session-providers
branch
5 times, most recently
from
December 5, 2024 16:54
8de7484
to
b894fcf
Compare
R0MANDEV
force-pushed
the
PROVIDER-1959-tests-branded-session-providers
branch
17 times, most recently
from
December 9, 2024 14:44
ab233e1
to
04132d3
Compare
R0MANDEV
force-pushed
the
PROVIDER-1959-tests-branded-session-providers
branch
5 times, most recently
from
December 9, 2024 15:58
36c723b
to
5ab93c2
Compare
R0MANDEV
force-pushed
the
PROVIDER-1959-tests-branded-session-providers
branch
from
December 10, 2024 13:57
5ab93c2
to
a7d9d6e
Compare
danigargar
requested changes
Dec 10, 2024
Comment on lines
+66
to
+74
const { | ||
username, | ||
realm, | ||
authUsername, | ||
authPassword, | ||
authProxy, | ||
expires, | ||
multiDdi, | ||
} = editDdisProvidersRegistrations.request; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
const { | |
username, | |
realm, | |
authUsername, | |
authPassword, | |
authProxy, | |
expires, | |
multiDdi, | |
} = editDdisProvidersRegistrations.request; | |
const data = editDdisProvidersRegistrations.request; | |
delete domain; | |
delete data.contactUserName; | |
delete ddiProvider; |
Just a suggestion. Don't you think it reads better this way? You know what you are skipping.
You may also just delete those fields from json fixture. What matters for pact files generation is whatever is actually posted.
Kaian
force-pushed
the
bleeding
branch
2 times, most recently
from
December 12, 2024 08:26
df24ab3
to
842b736
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type Of Change
Checklist:
Description
Additional information