Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup from the move from "Reframe" to "HTTP Delegated Routing" #9479

Closed
8 tasks done
guseggert opened this issue Dec 7, 2022 · 6 comments · Fixed by #10372
Closed
8 tasks done

Cleanup from the move from "Reframe" to "HTTP Delegated Routing" #9479

guseggert opened this issue Dec 7, 2022 · 6 comments · Fixed by #10372
Assignees
Labels
kind/enhancement A net-new feature or improvement to an existing feature

Comments

@guseggert
Copy link
Contributor

guseggert commented Dec 7, 2022

Done Criteria

Code and docs are clear that "HTTP Delegated Routing" is what is supported/maintained currently. References to Reframe should be updated.

Why Important

Now that we have the /routing/v1 HTTP API client integrated, and Reframe has been deprecated for two releases (0.17, 0.18), we should remove it in 0.19 to avoid user confusion.

Notes

Cleanup items

  1. skip/changelog
@guseggert guseggert added the kind/enhancement A net-new feature or improvement to an existing feature label Dec 7, 2022
@guseggert guseggert self-assigned this Dec 7, 2022
@guseggert guseggert moved this to 🥞 Todo in IPFS Shipyard Team Dec 7, 2022
@BigLep BigLep changed the title Remove reframe Cleanup from the move from "Reframe" to "HTTP Delegated Routing" Dec 8, 2022
@lidel
Copy link
Member

lidel commented Dec 8, 2022

cc @tinytb @achingbrain for visibility, as some of this impacts routing options for JS in browser.

Namely, if we don't plan to do delegated routing over libp2p protocol any time soon, then at very least we need DHT(+HTTP IPNI) racing proxy at routing.delegate.ipfs.io/, and that means we need to update someguy to IPIP-337

@aschmahmann
Copy link
Contributor

aschmahmann commented Dec 9, 2022

@lidel correct, but also IPIP-337 is insufficient as is in that it doesn't support streaming, nor does it support IPNS. While in theory you could rely on IPIP-351 for IPNS resolution it too will not support streaming.

Perhaps you could argue IPNS doesn't want streaming, and endpoints should just use some heuristic to decide on their end what's "good enough" and return a single value, however that could also cause problems with consistency among IPNS records with overlapping validity (e.g. someone who publishes updates daily with record EOLs a year in the future).

@BigLep
Copy link
Contributor

BigLep commented Mar 20, 2023

2023-03-20 discussion amongst @guseggert @lidel and @aschmahmann was to name this "Routing v1 HTTP API"

TorfinnOlsen added a commit to TorfinnOlsen/IPFS-specs that referenced this issue Apr 3, 2023
Noticed a sentence I'd duplicated and revised it to make note of the 'Routing V1' title referenced here: ipfs/kubo#9479
@lidel lidel assigned hacdias and unassigned guseggert Jun 15, 2023
@lidel
Copy link
Member

lidel commented Jun 15, 2023

reassigning to @hacdias as he already had to remove remaining Reframe references from Kubo in #9932 👍

@lidel lidel self-assigned this Jul 6, 2023
@BigLep BigLep mentioned this issue Aug 3, 2023
@hacdias hacdias moved this from 🥞 Todo to 🏃‍♀️ In Progress in IPFS Shipyard Team Aug 9, 2023
@BigLep BigLep moved this from 🏃‍♀️ In Progress to 🥞 Todo in IPFS Shipyard Team Aug 9, 2023
@hacdias hacdias moved this from 🥞 Todo to 🏃‍♀️ In Progress in IPFS Shipyard Team Aug 10, 2023
@hacdias
Copy link
Member

hacdias commented Aug 25, 2023

I think as of #9877, we can successfully close this.

@hacdias hacdias closed this as completed Aug 25, 2023
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In Progress to 🎉 Done in IPFS Shipyard Team Aug 25, 2023
@BigLep
Copy link
Contributor

BigLep commented Aug 25, 2023

@hacdias: a couple of thoughts:

  1. Is there more removal/cleanup we should do in Kubo: https://github.com/search?q=repo%3Aipfs%2Fkubo%20reframe&type=code ?
  2. Maybe add a followup note to to https://blog.ipfs.tech/2022-09-02-introducing-reframe/ (can be as a discussion form comment or in the blog post itself) saying that reframe has been replaced by /routing/v1 (and ideally link to the IPIP where the justification was provided)

@BigLep BigLep reopened this Aug 25, 2023
lidel added a commit to ipfs/ipfs-blog that referenced this issue Mar 18, 2024
This takes care of some outdated blogposts pointing at Reframe.
We point at /routing/v1 instead, and add disclaimers where needed.

Context: ipfs/kubo#9479
lidel added a commit that referenced this issue Mar 18, 2024
2color pushed a commit to ipfs/ipfs-blog that referenced this issue Mar 22, 2024
This takes care of some outdated blogposts pointing at Reframe.
We point at /routing/v1 instead, and add disclaimers where needed.

Context: ipfs/kubo#9479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A net-new feature or improvement to an existing feature
Projects
No open projects
Status: 🎉 Done
Development

Successfully merging a pull request may close this issue.

5 participants