Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Nil" CIDs #44

Open
Stebalien opened this issue Sep 25, 2018 · 0 comments
Open

"Nil" CIDs #44

Stebalien opened this issue Sep 25, 2018 · 0 comments

Comments

@Stebalien
Copy link
Member

We're now using cid.Cid{} (empty) as the "nil" CID. Unfortunately, refmt won't encode this to null. With polydawn/refmt#36, we can at least omit empty CIDs however, we still need to be able to do something intelligent with empty/nil CIDs.

  • We could just panic or return an error but, IMO, we should do something a bit smarter.
  • We can also inject a token "mapper" to transform the token stream. It may be worth adding this feature to atlas entries?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant