Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Query Paramater to avoid copying Value's data? #59

Open
kevina opened this issue Nov 23, 2016 · 1 comment
Open

Provide Query Paramater to avoid copying Value's data? #59

kevina opened this issue Nov 23, 2016 · 1 comment
Labels
status/deferred Conscious decision to pause or backlog

Comments

@kevina
Copy link
Contributor

kevina commented Nov 23, 2016

When NextSync() is used it is safe to avoid copying the Value's data. This will help mostly with go-ds-leveldb queries see libp2p/go-libp2p-kad-dht#39.

@whyrusleeping Do you think this is a good idea? If this paramater is provided it will be an error to call either the Next() or Process() methods on the results.

@kevina
Copy link
Contributor Author

kevina commented Nov 23, 2016

From IRC:

whyrusleeping: kevina: yeah, lets punt on doing the zero-copy values for now
whyrusleeping: I definitely want that at some point, but lets not rock the boat too much here
whyrusleeping: the reason i'm more hesitant on this one is that misuse of that feature can lead to some pretty subtle bugs

@whyrusleeping whyrusleeping added the status/deferred Conscious decision to pause or backlog label Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/deferred Conscious decision to pause or backlog
Projects
None yet
Development

No branches or pull requests

2 participants