fix(gw): IPIP-402 CARs return useful blocks on not found errors #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
force-pushed
the
fix/gateway-ipip-402-car-return-err-blocks
branch
from
59cac29
to
7edb8a4
Compare
…due to discovery errors, only IPLD errors
…stead of just erroring
aschmahmann
force-pushed
the
fix/gateway-ipip-402-car-return-err-blocks
branch
from
7edb8a4
to
eb36550
Compare
aschmahmann
commented
Aug 17, 2023
Codecov Report
@@ Coverage Diff @@
## main #440 +/- ##
==========================================
- Coverage 50.15% 49.50% -0.65%
==========================================
Files 249 246 -3
Lines 29990 29946 -44
==========================================
- Hits 15041 14825 -216
- Misses 13514 13688 +174
+ Partials 1435 1433 -2
|
lidel
changed the title
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Aug 17, 2023
This aims to test ipfs/boxo#440 against ipfs/gateway-conformance#131
lidel
added a commit
to ipfs/kubo
that referenced
this pull request
Aug 17, 2023
This aims to test ipfs/boxo#440 against ipfs/gateway-conformance#131
lidel
approved these changes
Aug 17, 2023
hacdias
approved these changes
Aug 18, 2023
hacdias
reviewed
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix extracted from #369 that could be suitable for a patch release.