Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_comparable_areas is not returning the right columns #327

Open
ariaker opened this issue Oct 18, 2023 · 4 comments
Open

read_comparable_areas is not returning the right columns #327

ariaker opened this issue Oct 18, 2023 · 4 comments
Assignees

Comments

@ariaker
Copy link

ariaker commented Oct 18, 2023

The data I can pull using read_comparable_areas is wrong. The table contains the columns code_amc, list_code_muni_2010, list_name_muni_2010, and geom. The columns list_code_muni_2010 and list_name_muni_2010 always contain the same information, and there is nothing about IBGE codes from each of the start or end years.

I have checked this for dozens of different year-pairs.

I am using the 1.8.1 version of the package in R 4.2.2.

@rafapereirabr
Copy link
Member

@PedroJorge7 , could you please have a look at this ?

@ariaker
Copy link
Author

ariaker commented Dec 5, 2023

@PedroJorge7 , could you please have a look at this ?

Any update on this?

@fbrustolin-fep
Copy link

I'm using geobr_1.8.1 in R version 4.3.2 (2023-10-31 ucrt) / Platform: x86_64-w64-mingw32/x64 (64-bit) / Running under: Windows 10 x64 (build 19045) and the list_code_muni_2010 seems to be OK, but list_name_muni_2010 also return the codes, not the municipalities names. Data was downloaded on read_comparable_areas(start_year = 1970, end_year = 2010, simplified = TRUE, showProgress = TRUE) call.

@PedroJorge7
Copy link
Contributor

PedroJorge7 commented Dec 12, 2023

Hello @ariaker,

I apologize for the delay response. During this period, we have been conducting several tests and making adjustments to our AMC code. As @fbrustolin-fep pointed out, in my results, I found that the list_code_muni_2010 seems to be OK, but the list_name_muni_2010 was incorrect. We made an adjustment in this column and also changed the column name to always align with the end year. So, if the end_year argument is 1960, the column should be named list_code_muni_1960. We will be uploading these adjustments soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants