Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift Package Manage support #14

Open
ekimia opened this issue Sep 18, 2020 · 13 comments
Open

Swift Package Manage support #14

ekimia opened this issue Sep 18, 2020 · 13 comments

Comments

@ekimia
Copy link

ekimia commented Sep 18, 2020

now that it supports binaries, would be a great addition especially since carthage is pretty buggy in xcode 12

@Lucky1st
Copy link

+1

@rmigneco
Copy link

The URBN team is also requesting SPM support.

@ryang1428
Copy link

Any updates here?

@ashley-campbell-iovation
Copy link
Contributor

Hello!

We expect sometime soon to be releasing an XCFramework that may resolve some of these issues. Do you believe this will resolve your concern?

Thanks!
Ashley

@ekimia
Copy link
Author

ekimia commented Feb 4, 2021

@ashley-campbell-iovation thats part of it. They need to take a look at the Declare a Binary Target in the Package Manifest
section at this link: https://developer.apple.com/documentation/swift_packages/distributing_binary_frameworks_as_swift_packages

@rmigneco
Copy link

rmigneco commented Feb 4, 2021

@ashley-campbell-iovation A XCFramework would be a great start! We'd love to have SPM support because it would make installation much simpler for the 3 clients we use at URBN. Its also much easier to update to new versions with SPM. Thanks!

@ashley-campbell-iovation
Copy link
Contributor

Hello all,

I wanted to announce that the XCFrameworks bundle is now available. I will update again when official SPM support is available.

Thanks!
Ashley

@tomfclearscore
Copy link

This might also fix issues building projects that use this SDK on M1 Macs without doing so via Rosetta.

@ashley-campbell-iovation
Copy link
Contributor

@tomfclearscore I'm interested in this use case. Are you having difficulty building iOS Apps on an M1 Mac in general or are you trying to build an iOS App as a MacOS App using the M1 capability?

Thanks!
Ashley

@ekimia
Copy link
Author

ekimia commented May 18, 2021 via email

@tomfclearscore
Copy link

@ashley-campbell-iovation The issues tend to be when building an iOS app on an M1 Mac targeting the simulator - in the normal way. I haven't looked into it deeply, but the difficulty seems to be when a linked framework wasn't built with an architecture slice required for simulators on M1 specifically. Fine building for a physical device target, and also fine when using Rosetta.

The problem doesn't seem to exist with most SPM packages since they're built from source, so Xcode is able to build what it needs.

@rickarddahlffcg
Copy link

rickarddahlffcg commented Oct 15, 2021

I think what is missing and needs to be added for the simulator slice is arm64 support like this:
ios-arm64_x86_64-simulator

This is what the current simulator slice for v5.2 looks like:
_ios-x86_64-simulator

@hisaac
Copy link

hisaac commented Feb 9, 2022

I've opened a pull request to add Swift Package Manager support to this library (#32). It remains to be seen if the maintainers will want to use it, but in the meantime, feel free to use my fork to integrate the library into your projects! https://github.com/hisaac/deviceprint-SDK-iOS/tree/add-spm-support

Note: I was able to add the library to an existing project of mine, and confirmed that the project built with this as a dependency. My team is just exploring using this library though, so we have not yet implemented it in our project, meaning I have not been able to actually test the library yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants