Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Fix wrong generated mana for spent outputs #1467

Closed
begonaalvarezd opened this issue May 7, 2024 · 0 comments · Fixed by #1464
Closed

[Task]: Fix wrong generated mana for spent outputs #1467

begonaalvarezd opened this issue May 7, 2024 · 0 comments · Fixed by #1464
Assignees
@msarcev
Milestone
E00.M4 - Nova Net...

Comments

@begonaalvarezd
Copy link
Member

Task description

Both passive mana (stored, potential, decay) and rewards are wrong when the output is spent.

  • For passive mana, we are using the wrong creation slot, from the output metadata we are using spent.slot when we should use computeSlotFromWhatever(spent.transactionId)
  • For rewards, we should pass the spent slot to the query to the node, the nodes dont track spent outputs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msarcev msarcev

Labels
None yet
Projects
None yet
Milestone
E00.M4 - Nova Networks Backlog
Development

Successfully merging a pull request may close this issue.

Fix: mana calculation in output and address pages iotaledger/explorer
2 participants
@begonaalvarezd @msarcev