Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Refactor useTangleStore and visualizer-three imports #1196

Closed
VmMad opened this issue Feb 28, 2024 · 0 comments
Closed

[Task]: Refactor useTangleStore and visualizer-three imports #1196

VmMad opened this issue Feb 28, 2024 · 0 comments

Comments

@VmMad
Copy link
Member

VmMad commented Feb 28, 2024

Task description

#1193 (comment)
#1193 (comment)

Export from an index.ts public files from visualizer-three and leave internal files out of this index.ts.

Integrate all blockIdToX into a single store. Suggestion blockIdToData.

blockIdToIndex: Map<string, number>;
blockIdToEdges: Map<string, EdgeEntry>;
blockIdToPosition: Map<string, [x: number, y: number, z: number]>;
blockIdToMetadata: Map<string, IFeedBlockData & { treeColor: Color }>; // rename it from blockMetadata
blockIdToAnimationPosition: Map<string, IBlockAnimationPosition>;
blockIdToState: Map<BlockId, BlockState>;
@VmMad VmMad added this to the E01.M2 - Nova Visualizer milestone Feb 28, 2024
@panteleymonchuk panteleymonchuk self-assigned this Feb 29, 2024
@begonaalvarezd begonaalvarezd closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants