-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltips for server settings #519
Comments
I like it, it's a good idea :)! |
Is the code here okay? If the code is okay then I'll do it. |
I think that you should put that code in the main .css file (it should be compact.css). |
I know that. The main thing is that the code was not bad :) I'm asking about it :) |
I know a very little of css, but it seems fine to me. |
You can make the change. |
Please tell me what the "Evasion Speed" and "Tourn Threshold" parameters mean in the settings. |
Evasion speed: the time your troops spend to return home after an evasion. |
Having looked at this file, I saw only that this parameter affects the number of sent scouts of the natars
The number of warriors created in the villages of Natars depends on the speed of the server:
|
It's wrong then. It's not a problem though, Natars troops spawn will be reworked soon, their spawn will be based of top 100 best mains in the server. |
So it does not make sense to write tooltips for this Natars Units Multiplier since it will be deleted? |
So the question about the Evasion Speed. According to the standard, this is equal to 1. Ie if the player puts time 1 this equals one minute (in the attack the troops will be missing one minute). If we put 2 in the admin panel and the player sets 1 minute, will it be 2 minutes or 30 seconds (in the attack the troops will be missing 2 minutes or 30 seconds)? |
@phaze1G Can you take a look at the code specified in the first message? |
I checked and it's good. I did CSS for @Shadowss request in 2 posts above. |
I'm thinking about what could remake the CSS for something more colorful. Maybe you can suggest something for this. And in occasion of that that has offered @Shadowss that I think that it will look absolutely on another. This was taken from T4+ and there the withdrawal of troops works only for the capital. In our code as far as I understand it works for all villages. |
@velhbxtyrj I don't like colorful things. I'm always sticking to 1-3 colors which are just small variants of the first one. for the tooltip maybe making it transparent and smaller? |
@velhbxtyrj, the evasion speed should be (180 seconds / server speed) |
They look good! Good job :)! I think that you can continue the same. |
@iopietro I ran into a little problem. I started filling the configuration file during installation and found out that it was not connected to the language package (( |
Mmh, I think that it would be more easy connecting the "Lang/en.php" file to the installation and in the future we could make a button for choosing the installation language. |
I tried to connect and it did not work :) Try it :) |
Ok, I'll try it. |
I tried it and it "works", but a lot of errors are displayed, so we should create a different language file for the installation, or we can just split the en.php file into specified files. For example we can create a folder for each language and put in it all languages file: GameEngine/Lang/en/building.php | GameEngine/Lang/en/installation.php etc. Let me know if you like it or not. |
I think can split the file into specified files. One for installation, one for the admin area, one for the game. Unless, of course, it does not take much time for this :) |
It looks great! |
Who will update the GITHUB buttons ? |
One more idea, we should replace the most of things we can with css instead of images. Rest of the stuff should be added as sprites css image. It would increase load speed by at least 30%. |
Can you do that ? I can give you access on the repository |
@phaze1G, They're awesome, great job :)! |
@phaze1G : i give you an invitation for Collaborator. You can change now. |
I don't want to mess the code, I'm kinda new to GitHub functions. PS: Changing images to CSS for buttons require editing every .php file and including text + class. For example:
|
@phaze1G, Don't worry, github uses "git", every commit can be reverted without problems, edit as much code as you want. If you're not sure, you can fork this project, edit it from your fork and then create a pull request to this project, so we can look at the changes before committing them to the master branch. |
@iopietro Can you explain me it a bit more, I just added CSS for new buttons and it added directly to master branch. How should I edit and make pull requests? Should I do it with the desktop client or directly go to file in browser and edit? |
Maybe you can reduced loads with 30% like you said |
@phaze1G, If you want to do pull requestes, you have to fork this project and then edit things in the fork you've made (you can fork it by clicking "Fork" here: https://github.com/Shadowss/TravianZ). After editing things in your fork you can open a pull request (from your fork) by clicking on "New pull request" in the main page of your fork. If you want to commit many files at once, in different folders, etc. I advice you to use a git client, I personally use "TortoiseGit" (https://tortoisegit.org/), imho one of the simpler git client in circulation. You can configure it simply by following this guide http://robertgreiner.com/2010/02/getting-started-with-git-and-tortoisegit-on-windows/ (the first I've found on google). After configuring TortoiseGit (or any other git client), you have to clone your fork repository or this project repository. You can do that by openin the context menu in a folder you like, and then clicking on "Git Clone" (this is the procedure for TortoiseGit) and then pasting this repository or your fork git clone url (https://github.com/Shadowss/TravianZ.git). You can obtain the "Git clone url" clicking on "Clone or download" in the main page of this project. For any doubts feel free to ask :) . |
It is necessary to decide.
|
I prefer the second one. |
agree |
I made the second option. @iopietro I want to ask you to read and if necessary correct the texts. Link with the beginning of the texts below :) |
@phaze1G you said : One more idea, we should replace the most of things we can with css instead of images. Rest of the stuff should be added as sprites css image. It would increase load speed by at least 30%. Can you do that for us ? Reducing load with 30% is great for our servers and for our version. |
There are dozen of images and ill need help from others too. Ill replace the much i can when i have free time |
Great , thanks @phaze1G |
friends , don't forget of include this in translation files 😃 really good job! |
Another one: https://jsfiddle.net/h1yzL6fs/ |
I like it! |
Really nice! |
@Shadowss @iopietro @phaze1G @eliopinho |
I like 3 :) |
I like the third too, but i can't see it and the second from firefox. |
OK. Tomorrow I'll try to work on it and fix it for firefox. |
Always keep font default or web safe. This one you used is not for web purposes. |
I have a little doubt that I would implement this. Does not work for old IE. And this browser is still used. The number of users is small, but we should not do what will be unpleasant for them. |
I offer for your consideration a few decorations for the admin panel: tooltips for server settings.
Who and what thinks about it?
Some code:
The text was updated successfully, but these errors were encountered: