You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
When MSBuild build fails, ProjInfo logs full MSBuild output which is very verbose.
It happens here:
Log.setMessageI $"Overall Build: {result.OverallResult:overallCode}, projects built {projectsBuilt:count} : {msbuildMessage:msbuildMessage} "
>> Log.addExn result.Exception
)
Sample beginning of output:
[14:18:37 INF] Ionide.ProjInfo.WorkspaceLoaderViaProjectGraph : Started loading projects 20 ["C:\\projekty\\fsharp\\fsharp_scripts\\.cache\\dotnet__fsharp\\9ae94bb9\\_\\tests\\service\\data\\CSharp_Analysis\\CSharp_Analysis.csproj", ...]
[14:18:39 ERR] Ionide.ProjInfo.WorkspaceLoaderViaProjectGraph : Overall Build: Failure, projects built 20 : Build started.
Static graph loaded in 1.055 seconds: 30 nodes, 72 edges
Project "CSharp_Analysis.csproj" (ResolveAssemblyReferencesDesignTime;ResolveProjectReferencesDesignTime;ResolvePackageDependenciesDesignTime;FindReferenceAssembliesForReferences;_GenerateCompileDependencyCache;_ComputeNonExistentFileProperty;BeforeBuild;BeforeCompile;CoreCompile target(s)):
...
(followed by a lot of MSBuild output)
Describe the solution you'd like
Better control over how much output is produced in case of failure.
Describe alternatives you've considered
Disable ProjInfo's logs through Serilog configuration - but that gets rid of useful log information.
The text was updated successfully, but these errors were encountered:
safesparrow
changed the title
Consider not outputting full MSBuild output on a failed build
Consider not logging full MSBuild output on a failed build
Feb 18, 2024
remove the long message from the existing logger message
add another, very-high-verbosity message that logs the build message
However, we should move to making that build message only generated logged in the first place if the verbosity is at a certain level, because that huge string in memory can't be doing well for our overall allocations.
Is your feature request related to a problem? Please describe.
When MSBuild build fails, ProjInfo logs full MSBuild output which is very verbose.
It happens here:
proj-info/src/Ionide.ProjInfo/Library.fs
Lines 1062 to 1065 in 22b59a7
Sample beginning of output:
Describe the solution you'd like
Better control over how much output is produced in case of failure.
Describe alternatives you've considered
Disable ProjInfo's logs through Serilog configuration - but that gets rid of useful log information.
The text was updated successfully, but these errors were encountered: