feat: add value accessors to the directives array #437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value accessor directives also need to be declared in the module file. This is achieved here by adding them to the directives array file, since it is assumed that the module declares and exports all elements of this array.
Pull request checklist
npm run build
) was run locally for affected output targetsnpm test
) were run locally and passednpm run prettier
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The value accessor directives have to be added to the angular module manually.
Issue URL: #436
What is the new behavior?
The value acessor directives are included in the directivesArrayFile and thereby declared and exported by a module file as described in the angular integration guide (https://stenciljs.com/docs/angular#adding-the-angular-output-target)
Does this introduce a breaking change?
The value accessors need to be removed from the public-api exports, since they are not copied any more.
The only export necessary hereafter is
This line should added to the angular integration guide (https://stenciljs.com/docs/angular#adding-the-angular-output-target)