Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add value accessors to the directives array #437

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AndreasIllg-COS
Copy link

The value accessor directives also need to be declared in the module file. This is achieved here by adding them to the directives array file, since it is assumed that the module declares and exports all elements of this array.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally for affected output targets
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The value accessor directives have to be added to the angular module manually.

Issue URL: #436

What is the new behavior?

The value acessor directives are included in the directivesArrayFile and thereby declared and exported by a module file as described in the angular integration guide (https://stenciljs.com/docs/angular#adding-the-angular-output-target)

Does this introduce a breaking change?

  • Yes
  • No

The value accessors need to be removed from the public-api exports, since they are not copied any more.
The only export necessary hereafter is

export * from './lib/stencil-generated/value-accessors';

This line should added to the angular integration guide (https://stenciljs.com/docs/angular#adding-the-angular-output-target)

The value accessor directives also need to be declared in the module file.
This is achieved here by adding them to the directives array file,
since it is assumed that the module declares and exports all elements of this array.
@christian-bromann
Copy link
Member

@Samg983 after your changes from #459 were merged and released, what do you think about this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants