-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(angular): recreate angular test app #358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna tag @tanner-reits to give a more thorough Angular review. I had a few high level questions, but not blocking on them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be missing something, but do we need the Vue-related changes in this file in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an autogenerated file. When previous PRs changed the vue output target, they did not run npm run build
from the example Stencil project, so the output targets output wasn't updated.
When updating the other framework example apps, these files will be removed from source control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I take it that these tests (in __tests__
) are the ones mentioned in the PR summary?
It has opinionated tests for components that act similar to Ionic Framework, but are beyond the scope for this integration.
Does that mean that we don't plan on backfilling/adding tests to the new test app? Or that those will just be coming in a future PR?
EDIT: Ah, maybe https://github.com/ionic-team/stencil-ds-output-targets/pull/358/files#diff-1e2b03b89f374dd1898b69732368234ce6b7b290a8b6dcd58b3bf10166b192ac is the replacement or sorts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct on the referenced test file. Future PRs will fill in expected integrations we want to account for with the generated proxies. Currently we have too complex of components and tests, than are necessary for what the output targets are responsible for. This was likely because we just copied the component structure from Ionic Framework.
We can probably set up a nightly CI against Ionic Framework if we wanted that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good from the Angular side 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing big stuck out to me. Had similar questions as Ryan, but those were addressed with your comments.
Closing in favor of #542 |
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally for affected output targetsnpm test
) were run locally and passednpm run prettier
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
The Angular test app is very outdated. It has opinionated tests for components that act similar to Ionic Framework, but are beyond the scope for this integration.
What is the new behavior?
my-button
to start (we can fill in new tests as we identify areas that we need coverage)Does this introduce a breaking change?
Other information
Will submit future PRs to upgrade the example Stencil lib to v3.