fix(android): parse environment variable provided paths with fs.realpath
#251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…path` this closes ionic-team#244, as it allows `native-run` to function as designed when various aspects of the Android SDK installation are referenced by symbolic links instead of real folder paths.
|
NOTE: as per my comment on the related issue, this PR isn't quite complete.. due to how Scoop installs the to re-iterate on my other comment: I would like to get back to this one, but I do not have time for this right now. as such, I'm going to close this PR for the moment. I'll work on the relevant changes in my fork as and when I have time, and start another PR when I have something worth sharing. 🖖🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this closes #244, as it allows
native-runto function as designed when various aspects of the Android SDK installation are referenced by symbolic links instead of real folder paths.