feat(google-maps): @googlemaps/js-api-loader: Refactor to importLibrary method #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AE1NS
force-pushed
the
maps-api-instance-check
branch
from
17d8c7e
to
cbf61a3
Compare
AE1NS
changed the title
AE1NS
changed the title
AE1NS
force-pushed
the
maps-api-instance-check
branch
4 times, most recently
from
06cd6a5
to
7e215e7
Compare
AE1NS
force-pushed
the
maps-api-instance-check
branch
from
7e215e7
to
4895b4a
Compare
AE1NS
force-pushed
the
maps-api-instance-check
branch
from
4895b4a
to
d37682f
Compare
AE1NS
force-pushed
the
maps-api-instance-check
branch
from
d37682f
to
efa1d87
Compare
AE1NS
changed the title
AE1NS
force-pushed
the
maps-api-instance-check
branch
from
efa1d87
to
e07002d
Compare
AE1NS
force-pushed
the
maps-api-instance-check
branch
from
e07002d
to
553e198
Compare
|
This is a minor but effective adjustment. What do you think about it? We are already using this in production for months and its the only way how we can use other google apis like geolocation or directions in parallel. |
rkitin
pushed a commit
to rkitin/capacitor-google-maps
that referenced
this pull request
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1586