Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(camera): add option to exclude Exif data on iOS #1328

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

robingenz
Copy link
Contributor

The pickImages function should only ask for permission if it is really necessary.
This is the case on iOS only when you need the Exif data (see comment). My client does not need this data and therefore wants to improve the UX by not asking permission for data that is not used.

Related to #1297 and #1325

@robingenz
Copy link
Contributor Author

The Capacitor File Picker plugin now supports this (see pickImages(...)).

@robingenz robingenz closed this Jan 8, 2023
@mesqueeb
Copy link

@robingenz since file picker and camera roll picker are separate, it's still useful to have this feature in the camera roll picker.

@robingenz
Copy link
Contributor Author

@mesqueeb Yes, it would be nice if this was also possible with the plugin. I reopened the pr.

@robingenz robingenz reopened this Feb 24, 2023
@kentora
Copy link

kentora commented Mar 27, 2023

This makes for much less confusion for the end users, and therefore would result in less 1 star reviews from 'paranoid' type users, complaining we can see pictures they did not agree to us seeing. I sure hope this can get merged

@kentora
Copy link

kentora commented Mar 28, 2023

A suggestion might be to add the option to exclude exif data when using getPhoto, as this can also redirect to showing the picker...

@fanckush
Copy link

any updates on this PR? it's gotten stale but I think it's very valuable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants