Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop test script to use nmtui utility #11

Closed
saravan2 opened this issue May 17, 2023 · 9 comments
Closed

Develop test script to use nmtui utility #11

saravan2 opened this issue May 17, 2023 · 9 comments
Assignees
Labels
enhancement New feature or request P1

Comments

@saravan2
Copy link

When nmtui is added to the image as part of : #9
We should modify the test script to allow the user to configure network and upload the test results.

@saravan2 saravan2 added the enhancement New feature or request label May 31, 2023
@saravan2 saravan2 moved this to P0 : Highest Priority in Development May 31, 2023
@santoshmahto7
Copy link
Contributor

WIP PR: #15

@saravan2
Copy link
Author

@davide125 Do we have a public AWS S3 Bucket endpoint where volunteers can submit the resctl-bench solutions ?

@santoshmahto7 Would redesign the script to upload the solution to that endpoint.

@saravan2 saravan2 added the P1 label Jun 28, 2023
@santoshmahto7
Copy link
Contributor

There is already an upload mechanism available in resctl-bench which uploads result to S3 bukcet with the help of lambda.
e.g

resctl-bench --resullt xxx-xxxx.json.gz  upload --upload-url <LAMBDA FUNCTION URL> 
resctl-bench --result resctl-bench-result_2023_05_01-19_18_49_1.json.gz upload --upload-url https://ygvr6jnjckwamfao5xztg6idiu0ukjeb.lambda-url.eu-north-1.on.aws/

Thus once lambda is operational, upload will automatically work together with issue update in iocost-benchmarks.
This task will only be required in case user want standalone upload without triggering lambda just to store his benchmarks.

@ewyler
Copy link

ewyler commented Aug 2, 2023

Sounds like this task is done if uploading to the API works. We wouldn't' want someone to be able to upload directly to the bucket - that's what the API is for, to control access. If someone wants to store benchmarks somewhere special for some reason, they can do that locally

@ewyler
Copy link

ewyler commented Aug 2, 2023

Though:

Thus once lambda is operational, upload will automatically work together with issue update in iocost-benchmarks.

Is the lambda operational now or is there more work to do?

@santoshmahto7
Copy link
Contributor

santoshmahto7 commented Aug 3, 2023

Though:

Thus once lambda is operational, upload will automatically work together with issue update in iocost-benchmarks.

Is the lambda operational now or is there more work to do?

All the code is merged, Last remaining thing is verifying/testing the deployment with internal AWS setup as tracked by task iocost-benchmark/iocost-benchmarks-ci#16. Someone from facebook team need to do that since I don't have internal aws access (Although I have tested in my aws local setup)

@ewyler
Copy link

ewyler commented Aug 4, 2023

I've pinged Davide to ask him to test this to verify it for you

@ewyler
Copy link

ewyler commented Aug 9, 2023

He'll test it next week

@ewyler
Copy link

ewyler commented Sep 6, 2023

This upload capability is already in the benchmark, so this isn't needed anymore

@ewyler ewyler closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2023
@ewyler ewyler moved this from P0 : Highest Priority to Done in Development Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1
Projects
Archived in project
Development

No branches or pull requests

3 participants